Align Types between Bulletin and SDK #10578
Open
+61
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondkfcheung
added
the
T1-FRAME
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump minor |
…time_dev --bump minor'
bkontur
approved these changes
Dec 9, 2025
bkontur
added
the
A4-backport-stable2512
acatangiu
approved these changes
Dec 9, 2025
franciscoaguirre
approved these changes
Dec 9, 2025
Comment on lines
64
to
69
| // TODO: find out what is "allocator" and "allocator limit" | ||
| // Setting higher limit also requires raising the allocator limit. | ||
| // TODO: not used, can we remove or use? | ||
| pub const DEFAULT_MAX_TRANSACTION_SIZE: u32 = 8 * 1024 * 1024; | ||
| // TODO: not used, can we remove or use? | ||
| pub const DEFAULT_MAX_BLOCK_TRANSACTIONS: u32 = 512; |
Contributor
There was a problem hiding this comment.
Can you create an issue for figuring this out and include the issue link on these comments? That way it won't fall through the cracks
Contributor
Author
There was a problem hiding this comment.
Created: #10591
bkontur
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR aligns types between Bulletin and SDK.
Addresses paritytech/polkadot-bulletin-chain#86
Relates to
StoragePeriodbetween Bulletin and SDK polkadot-bulletin-chain#134RuntimeDebugand replace it withDebug#10582