Deprecate RuntimeDebug and replace it with Debug
#10582
Conversation
I compared multiple builds which each other: | Runtime | RuntimeDebug .compact.wasm | Debug .compact.wasm | Δ bytes | Δ % | |---------|---------------------------|---------------------|---------|-----| | westend-runtime | 10,004,155 | 10,093,902 | +89,747 | +0.90% | | asset-hub-westend-runtime | 13,453,435 | 13,491,827 | +38,392 | +0.29% | | bridge-hub-westend-runtime | 6,975,911 | 7,078,591 | +102,680 | +1.47% | | collectives-westend-runtime | 6,660,307 | 6,725,426 | +65,119 | +0.98% | | people-westend-runtime | 5,639,941 | 5,661,539 | +21,598 | +0.38% | | coretime-westend-runtime | 5,667,343 | 5,689,961 | +22,618 | +0.40% | | glutton-westend-runtime | 2,502,303 | 2,514,727 | +12,424 | +0.50% | | Runtime | RuntimeDebug .compact.compressed.wasm | Debug .compact.compressed.wasm | Δ bytes | Δ % | |---------|--------------------------------------|--------------------------------|---------|-----| | westend-runtime | 1,911,531 | 1,918,414 | +6,883 | +0.36% | | asset-hub-westend-runtime | 2,402,348 | 2,408,262 | +5,914 | +0.25% | | bridge-hub-westend-runtime | 1,397,714 | 1,409,183 | +11,469 | +0.82% | | collectives-westend-runtime | 1,265,180 | 1,268,329 | +3,149 | +0.25% | | people-westend-runtime | 1,125,880 | 1,126,034 | +154 | +0.01% | | coretime-westend-runtime | 1,132,311 | 1,135,300 | +2,989 | +0.26% | | glutton-westend-runtime | 543,780 | 546,127 | +2,347 | +0.43% | | Runtime | RuntimeDebug .compact.wasm | Debug .compact.wasm | Δ bytes | Δ % | |---------|---------------------------|---------------------|---------|-----| | westend-runtime | 10,088,725 | 10,088,725 | 0 | 0.00% | | asset-hub-westend-runtime | 13,491,318 | 13,491,318 | 0 | 0.00% | | bridge-hub-westend-runtime | 7,078,244 | 7,078,244 | 0 | 0.00% | | collectives-westend-runtime | 6,724,948 | 6,724,948 | 0 | 0.00% | | people-westend-runtime | 5,640,009 | 5,661,591 | +21,582 | +0.38% | | coretime-westend-runtime | 5,689,735 | 5,689,735 | 0 | 0.00% | | glutton-westend-runtime | 2,504,593 | 2,517,004 | +12,411 | +0.50% | | Runtime | RuntimeDebug .compact.compressed.wasm | Debug .compact.compressed.wasm | Δ bytes | Δ % | |---------|--------------------------------------|--------------------------------|---------|-----| | westend-runtime | 1,917,250 | 1,917,250 | 0 | 0.00% | | asset-hub-westend-runtime | 2,408,382 | 2,408,382 | 0 | 0.00% | | bridge-hub-westend-runtime | 1,409,259 | 1,409,259 | 0 | 0.00% | | collectives-westend-runtime | 1,267,981 | 1,267,981 | 0 | 0.00% | | people-westend-runtime | 1,126,034 | 1,130,613 | +4,579 | +0.41% | | coretime-westend-runtime | 1,135,207 | 1,135,207 | 0 | 0.00% | | glutton-westend-runtime | 545,344 | 548,753 | +3,409 | +0.63% | This shows that the size increase is neglectable and not worth the increased hassle when it comes to debuggin inside wasm.
|
/cmd fmt |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
/cmd update-ui |
|
Command "update-ui" has started 🚀 See logs here |
|
Command "update-ui" has finished ✅ See logs here |
|
Isn't the runtime cost of logging large data instead of "stripped" also worth investigating? For example if we were to log a candidate's commitments that can be very large and definitely take a lot of time. |
The PR aligns types between Bulletin and SDK. Addresses paritytech/polkadot-bulletin-chain#86 Relates to * paritytech/polkadot-bulletin-chain#128 * paritytech/polkadot-bulletin-chain#134 * #10582 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Branislav Kontur <[email protected]>
The PR aligns types between Bulletin and SDK. Addresses paritytech/polkadot-bulletin-chain#86 Relates to * paritytech/polkadot-bulletin-chain#128 * paritytech/polkadot-bulletin-chain#134 * #10582 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Branislav Kontur <[email protected]> (cherry picked from commit 18cb5ee)
Why are you logging something like this in the first place when you could never read it? Because before we stripped the information. Generally
Relay chains + system chain are running this way. As most people copy our code, they have probably done the same. Generally I would assume this is the case and if not they can fix it. Still, we should not log things with |
|
/cmd prdoc --audience runtime_dev --bump minor |
…time_dev --patch major'
|
Command "prdoc --audience runtime_dev --bump minor" has failed ❌! See logs here |
|
/cmd prdoc --audience runtime_dev --bump minor |
|
Command "prdoc --audience runtime_dev --bump minor" has failed ❌! See logs here |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
I compared multiple builds which each other:
With
--features on-chain-release-build:This shows that the size increase is neglectable and not worth the increased hassle when it comes to debuggin inside wasm.
Closes: #3005