Skip to content

[stable2603] Backport #11332#11452

Merged
EgorPopelyaev merged 4 commits intostable2603from
backport-11332-to-stable2603
Mar 24, 2026
Merged

[stable2603] Backport #11332#11452
EgorPopelyaev merged 4 commits intostable2603from
backport-11332-to-stable2603

Conversation

@paritytech-release-backport-bot

Backport #11332 into stable2603 from lexnv.

See the documentation on how to use this bot.

This PR closes missing body gaps in the database for non-archive nodes.

Effectively, a missing body gap cannot be closed on the DB side if the
node is non-archive. Since execution is already skipped, the node will
close the memory gap in the sync engine; however, the gap remains open
in the db.

This leads to wasting resources at every startup:
- client info contains a gap that cannot be filled (since we don't have
the state around for execution)
- blocks are fetched from the connected peers
- gap is filled by ignoring blocks in the sync engine

Further, for collators on origin master this causes an infinite loop of
sync engine restarts that get punished via banning and disconnecting.
For more details and root cause check:
- #11330

Part of:
- #11299

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 0f64cfc)
@github-actions
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev enabled auto-merge (squash) March 23, 2026 15:21
@EgorPopelyaev EgorPopelyaev merged commit cf680ec into stable2603 Mar 24, 2026
246 of 249 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-11332-to-stable2603 branch March 24, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants