Collation Generation - ready for old relay parents#11456
Open
Collation Generation - ready for old relay parents#11456
Conversation
eskimor
changed the title
eskimor
added
T0-node
iulianbarbu
reviewed
Mar 23, 2026
iulianbarbu
reviewed
Mar 24, 2026
Comment on lines
+17
to
+18
| The `parent_head` field is removed from `SubmitCollationParams` — callers should set | ||
| `validation_data.parent_head` directly instead. |
Contributor
There was a problem hiding this comment.
This is already done in the block builder. Not sure though why it was important to modify validation_data.parent_head to the extra parent_head from SubmitCollationParams after requesting the persisted validation data from the runtime (in collation-generation).
iulianbarbu
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@iulianbarbu Haven't checked. Let me know if this is conflicting with any changes already done.
Fixes: #11423