revive: Skip redundant eth_block_hash RPC call in block subscription#11475
Open
revive: Skip redundant eth_block_hash RPC call in block subscription#11475
Conversation
insert_block_receipts already receives the ethereum block hash from the caller (via eth_block().hash), but extract_from_block was fetching it again via a separate state_call RPC. This redundant call occasionally stalls for 10-20s on public RPC nodes, causing the block cache to fall behind and the health check to report out-of-sync. Add extract_from_block_with_eth_hash that accepts a pre-fetched hash, and use it from insert_block_receipts. The original extract_from_block still fetches the hash for callers that don't have it.
pgherveou
force-pushed
the
pg/skip-redundant-eth-block-hash-rpc
branch
from
24796c7 to
390c5e0
Compare
marian-radu
approved these changes
Mar 24, 2026
pgherveou
added
the
T7-smart_contracts
0xRVE
approved these changes
Mar 24, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.