statement-store: defer statement protocol connections during major sync#11487
Draft
DenzelPenzel wants to merge 1 commit intomasterfrom
Draft
statement-store: defer statement protocol connections during major sync#11487DenzelPenzel wants to merge 1 commit intomasterfrom
DenzelPenzel wants to merge 1 commit intomasterfrom
Conversation
alexggh
reviewed
Mar 25, 2026
| }, | ||
| SyncEvent::PeerDisconnected(remote) => { | ||
| self.deferred_peers.retain(|(p, _)| *p != remote); | ||
| let result = self.network.remove_peers_from_reserved_set( |
Contributor
There was a problem hiding this comment.
Is this function actually disconnecting the nodes ? As far as I know they just get remove from reserved set but it does not mean they get disconnected.
Contributor
Author
There was a problem hiding this comment.
if reserved_only = true -> remove_peers_from_reserved_set does disconnect
SS setup the NonReservedPeerMode::Deny at protocol creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Nodes drop all statements received from peers during major sync because of the
is_major_syncing()guard.