- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.1k
 
          Extract block announce validation from ChainSync
          #1170
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            dmitry-markin
  merged 35 commits into
  master
from
dm-extract-block-announce-validation-from-chainsync
  
      
      
   
  Sep 4, 2023 
      
    
                
     Merged
            
            
  
    Extract block announce validation from ChainSync
  
  #1170
              
                    dmitry-markin
  merged 35 commits into
  master
from
dm-extract-block-announce-validation-from-chainsync
  
      
      
   
  Sep 4, 2023 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Co-authored-by: Aaro Altonen <[email protected]> Co-authored-by: Anton <[email protected]>
…m somewhere else
…nounce-validation-from-chainsync
              
                    dmitry-markin
  
              
              commented
              
                  
                    Aug 25, 2023 
                  
              
              
            
            
              
                    altonen
  
              
              approved these changes
              
                  
                    Aug 28, 2023 
                  
              
              
            
            
…nounce-validation-from-chainsync
…nounce-validation-from-chainsync
              
                    kpp
  
              
              approved these changes
              
                  
                    Aug 29, 2023 
                  
              
              
            
            
              
                    kpp
  
              
              reviewed
              
                  
                    Aug 29, 2023 
                  
              
              
            
            
…nounce-validation-from-chainsync
…nounce-validation-from-chainsync
| 
           Any reason this isn't merged yet?  | 
    
…nounce-validation-from-chainsync
          
 Last week one zombienet test was failing (I guess on master too), so I've been waiting for the CI to turn green.  | 
    
| 
           And now Check Markdown test is failing 🙈 EDIT: restart helped.  | 
    
    
  ordian 
      added a commit
      that referenced
      this pull request
    
      Sep 6, 2023 
    
    
      
  
    
      
    
  
* master: (24 commits) GHW for building and publishing docker images (#1391) pallet asset-conversion additional quote tests (#1371) Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226) Fix PRdoc check (#1419) Fix the wasm runtime substitute caching bug (#1416) Bump enumn from 0.1.11 to 0.1.12 (#1412) RFC 14: Improve locking mechanism for parachains (#1290) Add PRdoc check (#1408) fmt fixes (#1413) Enforce a decoding limit in MultiAssets (#1395) Remove dynamic dispatch using `Ext` (#1399) Remove redundant calls to `borrow()` (#1393) Get rid of polling in `WarpSync` (#1265) Bump actions/checkout from 3 to 4 (#1398) Bump thiserror from 1.0.47 to 1.0.48 (#1396) Move Relay-Specific Shared Code to One Place (#1193) rust docs: add simple analytics (#1377) Contracts: Update read_sandbox (#1390) Extract block announce validation from `ChainSync` (#1170) [ci] Remove runtime-benchmarks from tests (#1335) ...
    
  Ank4n 
      pushed a commit
      that referenced
      this pull request
    
      Sep 8, 2023 
    
    
  
    
  Daanvdplas 
      pushed a commit
      that referenced
      this pull request
    
      Sep 11, 2023 
    
    
  
    
  bgallois 
      pushed a commit
        to duniter/duniter-polkadot-sdk
      that referenced
      this pull request
    
      Mar 25, 2024 
    
    
  
    
  bkchr 
      pushed a commit
      that referenced
      this pull request
    
      Apr 10, 2024 
    
    
      
  
    
      
    
  
* register parachain relay subcommand * revert cargo patch * added basic test * fmt
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR is part of Sync 2.0 preparation work. Resolves #503.
Supersedes paritytech/substrate#14675, please see the discussion there for details.