-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Make zombienet CI great again #8748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job!
I have only a few comments related to inputs of a reusable github action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some nits remaining from me
| # We need to use an older version of polkadot/polkadot-parachain, particulary a version that doesn't includes | ||
| # https://github.com/paritytech/polkadot-sdk/pull/1644, and since this change is also used by the collators we need to | ||
| # keep this test to ensure that works with older versions. | ||
| - name: download_old_release_bins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we maybe abstract this into some script? I'm pretty sure other tests will need it too (and it's already duplicated for 2 tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do this later if you want, I really want us to start running zombienet tests again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, is alredy used twice. I will move the logic to a reusable action. Thx!!
polkadot/zombienet_tests/functional/0014-chunk-fetching-network-compatibility.toml
Outdated
Show resolved
Hide resolved
This PR re-enables Zombienet CI tests.
Changes:
- Enable Zombienet Polkadot and Substrate tests
- Zombienet Cumulus will be enabled separately, when being migrated to
`zombienet-sdk`
- Switch zombienet from `k8s` to `native` provider
`k8s` turned out to be unstable for both `zombienet` and
`zombienet-sdk`. Issues observed:
- problem with launching a pod
- pods (and thus nodes) were not spawned at the same time (differences
up to 120s), which affected some tests
- `kubectl` command failed
Observed many times for:
- kubectl cp
- kubectl exec
- kubectl logs
If we ever want to switch back to `k8s` we must ensure above issues no
longer exist.
- Tweaks some tests to make sure they constantly pass
Authors of those tests are kindly asked to review the changes.
- Some improvements and fixes `zombienet` and `zombienet-sdk` frameworks
- Assign more beefy runners for more demanding tests
Rule of thumb: use large runner if spawned network consist of more than
4 nodes
- Disable some tests to let their authors to stabilize them
Created a dedicated `.github/zombienet-flaky-tests` file for more
clarity
ATM there are 16 flaky tests. Their authors are kindly asked to fix them
and re-enable.
---------
Co-authored-by: Javier Viola <[email protected]>
Co-authored-by: Javier Viola <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anthony Lazam <[email protected]>

This PR re-enables Zombienet CI tests.
Changes:
zombienet-sdkk8stonativeproviderk8sturned out to be unstable for bothzombienetandzombienet-sdk. Issues observed:kubectlcommand failedObserved many times for:
If we ever want to switch back to
k8swe must ensure above issues no longer exist.Authors of those tests are kindly asked to review the changes.
zombienetandzombienet-sdkframeworksRule of thumb: use large runner if spawned network consist of more than 4 nodes
Created a dedicated
.github/zombienet-flaky-testsfile for more clarityATM there are 16 flaky tests. Their authors are kindly asked to fix them and re-enable.