Skip to content

Fix for promote_fast benchmark#9516

Merged
acatangiu merged 6 commits intomasterfrom
bko-core-fellows-bench
Aug 19, 2025
Merged

Fix for promote_fast benchmark#9516
acatangiu merged 6 commits intomasterfrom
bko-core-fellows-bench

Conversation

@bkontur
Copy link
Copy Markdown
Contributor

@bkontur bkontur commented Aug 19, 2025 •
edited
Loading

Discovered by: polkadot-fellows/runtimes#853

It’s likely that this PR: #7720 broke weight generation/compilation. For example, for promote_fast, the weight file is generated with u32—see the screenshot below, which causes compilation errors when MaxRank = u16.

image

TODO

  • find possible fix

@bkontur bkontur changed the title WIP: DNM(yet) Fix for WIP: DNM(yet) Fix for promote_fast benchmark Aug 19, 2025
@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Aug 19, 2025

/cmd bench --runtime collectives-westend --pallet pallet_core_fellowship

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 19, 2025

Command "bench --runtime collectives-westend --pallet pallet_core_fellowship" has started 🚀 See logs here

ggwpez
ggwpez approved these changes Aug 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should always be u32 AFAIK.

@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Aug 19, 2025

Should always be u32 AFAIK.

Because of the Linear which supports only u32, right?
So then we just need to change the weight trait probably: https://github.com/paritytech/polkadot-sdk/blob/master/substrate/frame/core-fellowship/src/weights.rs#L82

@github-actions
Update from github-actions[bot] running command 'bench --runtime coll…
bcf6681 
…ectives-westend --pallet pallet_core_fellowship'
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 19, 2025

Command "bench --runtime collectives-westend --pallet pallet_core_fellowship" has finished ✅ See logs here

Details

Subweight results:
File Extrinsic Old New Change [%]
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_ambassador_core.rs submit_evidence 266.89us 251.12us -5.91
Command output:

✅ Successful benchmarks of runtimes/pallets:
-- collectives-westend: ['pallet_core_fellowship']

@bkontur bkontur requested a review from a team as a code owner August 19, 2025 12:44
@bkontur bkontur added the T12-benchmarks This PR/Issue is related to benchmarking and weights. label Aug 19, 2025
@bkontur bkontur changed the title WIP: DNM(yet) Fix for promote_fast benchmark Fix for promote_fast benchmark Aug 19, 2025
@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Aug 19, 2025

/cmd prdoc --audience runtime_dev --bump patch --force

bkontur
bkontur commented Aug 19, 2025
View reviewed changes
@bkontur bkontur mentioned this pull request Aug 19, 2025
Merged
@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Aug 19, 2025

/cmd bench --runtime collectives-westend --pallet pallet_core_fellowship

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 19, 2025

Command "bench --runtime collectives-westend --pallet pallet_core_fellowship" has started 🚀 See logs here

@github-actions
Update from github-actions[bot] running command 'bench --runtime coll…
896ce45 
…ectives-westend --pallet pallet_core_fellowship'
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 19, 2025

Command "bench --runtime collectives-westend --pallet pallet_core_fellowship" has finished ✅ See logs here

Details

Subweight results:
File Extrinsic Old New Change [%]
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_ambassador_core.rs approve 415.66us 391.64us -5.78
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_ambassador_core.rs submit_evidence 266.89us 244.69us -8.32
Command output:

✅ Successful benchmarks of runtimes/pallets:
-- collectives-westend: ['pallet_core_fellowship']

@bkontur bkontur added A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-unstable2507 Pull request must be backported to the unstable2507 release branch and removed A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-unstable2507 Pull request must be backported to the unstable2507 release branch labels Aug 19, 2025
@acatangiu acatangiu added this pull request to the merge queue Aug 19, 2025
@bkontur bkontur added A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-unstable2507 Pull request must be backported to the unstable2507 release branch labels Aug 19, 2025
Merged via the queue into master with commit 4c8ccc5 Aug 19, 2025
283 of 297 checks passed
@acatangiu acatangiu deleted the bko-core-fellows-bench branch August 19, 2025 16:13
paritytech-release-backport-bot bot pushed a commit that referenced this pull request Aug 19, 2025
@bkontur @github-actions
Fix for promote_fast benchmark (#9516)
34127bd 
Discovered by: polkadot-fellows/runtimes#853

It’s likely that this PR:
[https://github.com/paritytech/polkadot-sdk/pull/7720](https://github.com/paritytech/polkadot-sdk/pull/7720)
broke weight generation/compilation. For example, for `promote_fast`,
the weight file is [generated with `u32`—see the screenshot
below](polkadot-fellows/runtimes@3cc49e4#diff-35dfb1113ee202c1375fb2d8982d02a665e5857fec2e0a07b684494c056c8901L190-R194),
which causes compilation errors when `MaxRank = u16`.

<img width="541" height="67" alt="image"
src="https://github.com/user-attachments/assets/03bb3d90-7c09-46c7-8990-21878fc50c61"
/>

## TODO

- [x] find possible fix

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 4c8ccc5)
@paritytech-release-backport-bot
Copy link
Copy Markdown

paritytech-release-backport-bot bot commented Aug 19, 2025

Successfully created backport PR for stable2506:

@paritytech-release-backport-bot paritytech-release-backport-bot bot mentioned this pull request Aug 19, 2025
Merged
paritytech-release-backport-bot bot pushed a commit that referenced this pull request Aug 19, 2025
@bkontur @github-actions
Fix for promote_fast benchmark (#9516)
4ba078b 
Discovered by: polkadot-fellows/runtimes#853

It’s likely that this PR:
[https://github.com/paritytech/polkadot-sdk/pull/7720](https://github.com/paritytech/polkadot-sdk/pull/7720)
broke weight generation/compilation. For example, for `promote_fast`,
the weight file is [generated with `u32`—see the screenshot
below](polkadot-fellows/runtimes@3cc49e4#diff-35dfb1113ee202c1375fb2d8982d02a665e5857fec2e0a07b684494c056c8901L190-R194),
which causes compilation errors when `MaxRank = u16`.

<img width="541" height="67" alt="image"
src="https://github.com/user-attachments/assets/03bb3d90-7c09-46c7-8990-21878fc50c61"
/>

## TODO

- [x] find possible fix

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 4c8ccc5)
@paritytech-release-backport-bot
Copy link
Copy Markdown

paritytech-release-backport-bot bot commented Aug 19, 2025

Successfully created backport PR for unstable2507:

@paritytech-release-backport-bot paritytech-release-backport-bot bot mentioned this pull request Aug 19, 2025
Merged
bkontur added a commit that referenced this pull request Aug 20, 2025
@paritytech-release-backport-bot @bkontur @github-actions
[stable2506] Backport #9516 (#9519)
bb71a69 
Backport #9516 into `stable2506` from bkontur.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bkontur added a commit that referenced this pull request Sep 5, 2025
@paritytech-release-backport-bot @bkontur @github-actions
[unstable2507] Backport #9516 (#9520)
e139d6c 
Backport #9516 into `unstable2507` from bkontur.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
@bkontur @github-actions @alvicsam
Fix for promote_fast benchmark (#9516)
5a5589d 
Discovered by: polkadot-fellows/runtimes#853

It’s likely that this PR:
[https://github.com/paritytech/polkadot-sdk/pull/7720](https://github.com/paritytech/polkadot-sdk/pull/7720)
broke weight generation/compilation. For example, for `promote_fast`,
the weight file is [generated with `u32`—see the screenshot
below](polkadot-fellows/runtimes@3cc49e4#diff-35dfb1113ee202c1375fb2d8982d02a665e5857fec2e0a07b684494c056c8901L190-R194),
which causes compilation errors when `MaxRank = u16`.

<img width="541" height="67" alt="image"
src="https://github.com/user-attachments/assets/03bb3d90-7c09-46c7-8990-21878fc50c61"
/>

## TODO

- [x] find possible fix

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggwpez ggwpez ggwpez approved these changes

@acatangiu acatangiu acatangiu approved these changes

Assignees

No one assigned

Labels

A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-unstable2507 Pull request must be backported to the unstable2507 release branch T12-benchmarks This PR/Issue is related to benchmarking and weights.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bkontur @ggwpez @acatangiu @pgherveou