-
Notifications
You must be signed in to change notification settings - Fork 24
llvm-builder testing workflow #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
64abd5b to
804cbaf
Compare
9b757b6 to
7914fe4
Compare
|
Okay, taking this PR back to draft, let's see how win & mac will run the tests |
a9a0f7b to
4457f98
Compare
|
Removed MacOS from the pipeline, these tests can't finish in 6h on public runners. |
But they shouldn't be executed as they are now only run on linux? Or am I missing something? |
Yes, that's what I'm saying. I've added them in previous revision; they didn't work, so I've removed them, leaving only linux. |
|
But now you only run the test on linux. It should run on all platforms. |
|
What I'm saying: They shouldn't be executed on macos because they are gated to only exist on linux. Which in turns allows for a matrix with all of our supported platforms. I'd like to have those tests detect problems early for all platforms we are releasing, not just Linux. |
|
Okay, it's coming back to me now 😅 I think we didn't undetstand each other, as I was talking about the whole test suite, while you were meant only the now gated tests; while both of us were referring to them as "tests" or "they" |
4457f98 to
9c6d91b
Compare
|
Yeah in the context of this PR with "tests" I mean the LLVM builder tests only 🙂 |
No description provided.