Skip to content

Conversation

@mutantcornholio
Copy link
Contributor

No description provided.

@mutantcornholio mutantcornholio marked this pull request as draft January 15, 2025 17:27
@mutantcornholio mutantcornholio force-pushed the yuri/pr-workflows branch 3 times, most recently from 64abd5b to 804cbaf Compare January 16, 2025 09:37
@mutantcornholio mutantcornholio force-pushed the yuri/pr-workflows branch 14 times, most recently from 9b757b6 to 7914fe4 Compare January 22, 2025 08:46
@mutantcornholio mutantcornholio changed the title [WIP]: testing workflows Testing workflows Jan 22, 2025
@mutantcornholio mutantcornholio marked this pull request as ready for review January 22, 2025 08:48
@mutantcornholio
Copy link
Contributor Author

Okay, taking this PR back to draft, let's see how win & mac will run the tests

@mutantcornholio mutantcornholio marked this pull request as draft January 23, 2025 10:09
@mutantcornholio mutantcornholio force-pushed the yuri/pr-workflows branch 4 times, most recently from a9a0f7b to 4457f98 Compare February 24, 2025 08:57
@mutantcornholio mutantcornholio changed the title Testing workflows llvm-builder testing workflow Feb 24, 2025
@mutantcornholio mutantcornholio marked this pull request as ready for review February 24, 2025 08:58
@mutantcornholio
Copy link
Contributor Author

Removed MacOS from the pipeline, these tests can't finish in 6h on public runners.

@xermicus
Copy link
Member

Removed MacOS from the pipeline, these tests can't finish in 6h on public runners.

But they shouldn't be executed as they are now only run on linux? Or am I missing something?

@mutantcornholio
Copy link
Contributor Author

Removed MacOS from the pipeline, these tests can't finish in 6h on public runners.

But they shouldn't be executed as they are now only run on linux? Or am I missing something?

Yes, that's what I'm saying. I've added them in previous revision; they didn't work, so I've removed them, leaving only linux.

@xermicus
Copy link
Member

But now you only run the test on linux. It should run on all platforms.

@xermicus
Copy link
Member

xermicus commented Feb 24, 2025

What I'm saying: They shouldn't be executed on macos because they are gated to only exist on linux. Which in turns allows for a matrix with all of our supported platforms. I'd like to have those tests detect problems early for all platforms we are releasing, not just Linux.

@mutantcornholio
Copy link
Contributor Author

Okay, it's coming back to me now 😅

I think we didn't undetstand each other, as I was talking about the whole test suite, while you were meant only the now gated tests; while both of us were referring to them as "tests" or "they"

@xermicus
Copy link
Member

xermicus commented Feb 24, 2025

Yeah in the context of this PR with "tests" I mean the LLVM builder tests only 🙂

@xermicus xermicus merged commit f1bce4f into main Feb 25, 2025
9 checks passed
@xermicus xermicus deleted the yuri/pr-workflows branch February 25, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants