Set the default PolkaVM stack and heap size values to 128KB. #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the camelCase serde attribute to the MemoryConfig and PolkaVM structs.
marian-radu
changed the title
marian-radu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes paritytech/contract-issues#149
A few test cases from v2-periphery-polkadot are hitting the PVM stack limit when the contracts are compiled using resolc version 0.5.0. The same tests pass if the contracts are compiled with a resolc version that includes commit: 878ca91.
After a brief discussion with @xermicus, we propose to set the default PolkaVM stack and heap size values to 128KB, since we have already encountered tests that hit the stack size limit and, without real world data, it is difficult to determine the optimal values.