Skip to content

Do not send more than one request per peer at a time #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaka wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Do not send more than one request per peer at a time #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30a07e4
Do not send more than one request per peer at a time
tomaka Jun 19, 2023
8dc4492
PR link
tomaka Jun 19, 2023
59075fe
Merge branch 'main' into proper-peers-selection
tomaka Jul 10, 2023
048f9cf
Fix warning
tomaka Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions lib/src/sync/all.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,7 @@ impl<TRq, TSrc, TBl> AllSync<TRq, TSrc, TBl> {
///
/// Panics if the [`SourceId`] is invalid.
///
// TODO: this function is questionable, because in practice we send requests to sources that are outside the scope of syncing
pub fn source_num_ongoing_requests(&self, source_id: SourceId) -> usize {
debug_assert!(self.shared.sources.contains(source_id.0));

Expand Down
1 change: 1 addition & 0 deletions light-base/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ async-channel = { version = "1.8.0", default-features = false } # TODO: no-std-
async-lock = { version = "2.7.0", default-features = false } # TODO: no-std-ize; this is has been done and is just waiting for a release: https://github.com/smol-rs/event-listener/pull/34
base64 = { version = "0.21.2", default-features = false, features = ["alloc"] }
blake2-rfc = { version = "0.2.18", default-features = false }
crossbeam-queue = { version = "0.3.8", default-features = false, features = ["alloc"] }
derive_more = "0.99.17"
either = { version = "1.8.1", default-features = false }
event-listener = { version = "2.5.3" }
Expand Down
Loading