Refactor build_raw_with_command for improved clarity#485
Open
SatoshiQaziMuhammed wants to merge 1 commit intoparitytech:mainfrom
Open
Refactor build_raw_with_command for improved clarity#485SatoshiQaziMuhammed wants to merge 1 commit intoparitytech:mainfrom
SatoshiQaziMuhammed wants to merge 1 commit intoparitytech:mainfrom
Conversation
This commit refactors the overly complex build_raw_with_command function in chain_spec.rs by extracting its responsibilities into smaller, focused helper methods. This improves code maintainability and readability. Changes: - Introduced ChainSpecPaths struct to encapsulate the three different path contexts (local, in_pod, in_args) used during chain spec generation - Extracted get_command_ref() and get_plain_path_ref() for cleaner error handling of option unwrapping - Extracted resolve_chain_spec_paths() to isolate complex path resolution logic based on command context and namespace capabilities - Extracted prepare_raw_spec_command() to handle command preparation including template replacement and --raw flag addition - Extracted parse_command_string() to separate string parsing concerns - Extracted execute_generate_command() to handle local vs remote command execution - Extracted finalize_raw_spec() to handle post-generation processing The refactored build_raw_with_command now reads as a clear sequence of high-level steps, making the function's intent and flow much easier to understand. All helper methods are single-responsibility and testable. Behavior is unchanged - this is a pure refactoring for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the overly complex build_raw_with_command function in chain_spec.rs by extracting its responsibilities into smaller, focused helper methods. This improves code maintainability and readability.
Changes:
The refactored build_raw_with_command now reads as a clear sequence of high-level steps, making the function's intent and flow much easier to understand. All helper methods are single-responsibility and testable.
Behavior is unchanged - this is a pure refactoring for clarity.