Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Many mechanisms exists for this purpose like Wasm or N(ode)-API but some may or

To demonstrate and learn which options fit the best for our use case, we will create a small test program which will have the following functionalities:

- Has a function taking an arbitratry object and a callback as parameters in the Typescript code, calling the callback with the function result on Rust side.
- Has a function taking an arbitrary object and a callback as parameters in the Typescript code, calling the callback with the function result on Rust side.
- Has a function taking an arbitrary object as parameter and a returning a promise in Typescript, signaling an asynchronous operation on Rust side.
- Make an HTTP request asynchronously in the Rust code, using a dependency using the standard library.

Expand Down Expand Up @@ -107,6 +107,6 @@ The prototype assume versions of `rustc` and `cargo` to be `1.69.0`, use of `sta

## Decision outcome

- ### **Napi-rs** for crates dependant on async, filesystem or networking: *support*, *orchestrator*, *test-runner*, *providers* from [schema](https://github.com/paritytech/zombienet-sdk/issues/22)
- ### **Napi-rs** for crates dependent on async, filesystem or networking: *support*, *orchestrator*, *test-runner*, *providers* from [schema](https://github.com/paritytech/zombienet-sdk/issues/22)

- ### **Wasm-pack** for the rest of the crates: *configuration* from [schema](https://github.com/paritytech/zombienet-sdk/issues/22)
2 changes: 1 addition & 1 deletion crates/examples/examples/para_upgrade.rs
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ async fn main() -> Result<(), anyhow::Error> {
.wait_metric(BEST_BLOCK_METRIC, |x| x > best_block + 50_f64)
.await?;

println!("Perfoming upgrade from path {wasm}");
println!("Performing upgrade from path {wasm}");

network
.parachain(100)
Expand Down
2 changes: 1 addition & 1 deletion crates/examples/examples/small_network_with_default.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
.await?;

println!("🚀🚀🚀🚀 network deployed");
// give some time to node's bootstraping
// give some time to node's bootstrapping
tokio::time::sleep(Duration::from_secs(12)).await;

// // Add a new node to the running network.
Expand Down
2 changes: 1 addition & 1 deletion crates/orchestrator/src/network.rs
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ impl<T: FileSystem> Network<T> {
/// * `timeout_secs` - The number of seconds to wait.
///
/// # Returns
/// * `Ok()` if the node is up before timeout occured.
/// * `Ok()` if the node is up before timeout occurred.
/// * `Err(e)` if timeout or other error occurred while waiting.
pub async fn wait_until_is_up(&self, timeout_secs: u64) -> Result<(), anyhow::Error> {
let handles = self
Expand Down
2 changes: 1 addition & 1 deletion crates/orchestrator/src/network/node.rs
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ impl NetworkNode {
/// * `timeout_secs` - The number of seconds to wait.
///
/// # Returns
/// * `Ok()` if the node is up before timeout occured.
/// * `Ok()` if the node is up before timeout occurred.
/// * `Err(e)` if timeout or other error occurred while waiting.
pub async fn wait_until_is_up(
&self,
Expand Down
2 changes: 1 addition & 1 deletion crates/orchestrator/src/network_spec/parachain.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ pub struct ParachainSpec {
/// Parachain id
pub(crate) id: u32,

/// Unique id of the parachain, in the patter of <para_id>-<n>
/// Unique id of the parachain, in the pattern of <para_id>-<n>
/// where the suffix is only present if more than one parachain is set with the same id
pub(crate) unique_id: String,

Expand Down
2 changes: 1 addition & 1 deletion crates/orchestrator/src/spawner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ where
let (rpc_port_external, prometheus_port_external, p2p_external);

if running_in_ci() && ctx.ns.provider_name() == "k8s" {
// running kubernets in ci require to use ip and default port
// running kubernetes in ci require to use ip and default port
(rpc_port_external, prometheus_port_external, p2p_external) =
(RPC_PORT, PROMETHEUS_PORT, P2P_PORT);
collator_full_node_prom_port_external = Some(FULL_NODE_PROMETHEUS_PORT);
Expand Down
2 changes: 1 addition & 1 deletion crates/provider/src/shared/scripts/zombie-wrapper.sh
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ start() {
# store pid
$ECHO ${child_pid} > $ZOMBIE_CMD_PID

# sleep a few secs to detect errors bootstraping the node
# sleep a few secs to detect errors bootstrapping the node
sleep 3

# check if the process is running
Expand Down
2 changes: 1 addition & 1 deletion crates/support/src/fs/local.rs
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ mod tests {
let test_dir = setup();
let fs = LocalFileSystem;
let path = format!("{test_dir}/somemissingfile");
// intentionnally don't create file
// intentionally don't create file

let err = fs.set_mode(&path, 0o400).await.unwrap_err();

Expand Down