feat: add support for overriding ethereum session key#2124
Open
DenzelPenzel wants to merge 1 commit intomainfrom
Open
feat: add support for overriding ethereum session key#2124DenzelPenzel wants to merge 1 commit intomainfrom
DenzelPenzel wants to merge 1 commit intomainfrom
Conversation
DenzelPenzel
force-pushed
the
session-key
branch
2 times, most recently
from
93a48a9 to
834a05e
Compare
DenzelPenzel
force-pushed
the
session-key
branch
from
834a05e to
c63a0ed
Compare
DenzelPenzel
changed the title
pepoviola
reviewed
Nov 21, 2025
|
|
||
| let eth_account: KeyringPair; | ||
| try { | ||
| eth_account = eth_keyring.createFromUri(uri); |
Collaborator
There was a problem hiding this comment.
I think the naming is somehow misleading, since the key is used as seed for generating the keypair.
ping @aurexav what's your expected behavior?
Collaborator
|
ping @DenzelPenzel, I think we need to change the naming to reflect the actual behavior. We are getting the seed for the eth key in the config, not the actual key. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1906