This repository was archived by the owner on Jan 6, 2026. It is now read-only.
add page_number parameter to download all pages of pdf files#179
Open
geoffreyp wants to merge 1 commit intoparkerhancock:masterfrom
Open
add page_number parameter to download all pages of pdf files#179geoffreyp wants to merge 1 commit intoparkerhancock:masterfrom
geoffreyp wants to merge 1 commit intoparkerhancock:masterfrom
Conversation
Owner
|
Thanks for this contribution! A few issues I noticed:
To download all pages, we'd need to either:
Would you be able to update the PR to address these issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem I'm solving is that you can only download the first page of the pdf documents in the global folder.
I've added a parameter to the global_dossier_api.get_document() method to download all the pages of a PDF file.