Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @danleyb2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue with the macOS installer by updating the Python environment path used during the build process to align with the current GitHub Actions runner setup. Additionally, a small debug print statement has been included to help verify the detected operating system platform during the build.
Highlights
- macOS Installer Path Update: The
site_packagespath for macOS builds within theplaterec_installer.specfile has been updated from Python 3.7.12 to Python 3.8.10. This ensures the installer correctly references the newer Python version in the GitHub Actions runner environment. - Platform Debugging Aid: A new
printstatement has been added toplaterec_installer.specto output thesys.platformvalue during the installer build process, which can assist in debugging platform-specific issues.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the hardcoded path for site-packages for macOS builds in the PyInstaller spec file, likely to fix a build failure on GitHub Actions. It also adds a debug print statement. My review focuses on improving the maintainability of this configuration. I've suggested removing the debug print and replacing the hardcoded path with a dynamic method to prevent future breakages when the build environment changes.
|
@marcbelmont @AashishDhakal Let's test the MAC executable produced from last build Note: windows and linux builds still use older pyinstaller version that runs on python3.7. Upgrading them requires an upgrade to the docker images |
|
@AashishDhakal |
|
@marcbelmont we should update https://api-storage.platerecognizer.com/installer/PlateRecognizer-Installer-MacOS |
|
@danleyb2 The macOS installer is now online |
3 participants
use python 3.8.10 pyinstaller==6.15.0 for mac