Added Dump method to enable manual request dumping#118
Open
petomalina wants to merge 1 commit intoparnurzeal:developfrom
Open
Added Dump method to enable manual request dumping#118petomalina wants to merge 1 commit intoparnurzeal:developfrom
petomalina wants to merge 1 commit intoparnurzeal:developfrom
Conversation
petomalina
changed the title
Author
|
There are two calls to |
Owner
|
Any clear example usecase? |
Author
|
I wanted to get the request before I actually sent it. |
parnurzeal
reviewed
Mar 5, 2017
|
|
||
| // Dump creates the required request and logs it's contents. | ||
| func (s *SuperAgent) Dump() { | ||
| req, err := s.MakeRequest() |
Owner
There was a problem hiding this comment.
We already have MakeRequest() before s.Debug.
You should not do it again here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created
Dumpmethod that allows user to dump the request at any time.This is usable while debugging.