EndStruct: Allow empty body not to return json failure#185
Open
aerostitch wants to merge 1 commit intoparnurzeal:developfrom
Open
EndStruct: Allow empty body not to return json failure#185aerostitch wants to merge 1 commit intoparnurzeal:developfrom
aerostitch wants to merge 1 commit intoparnurzeal:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes servers could send back empty body, and when that happens currently,
EndStruct()returns a json decoding error which can be confusing.Instead we could just avoid to unmarshall the body and leave the struct nil.
(I have an app that, depending on the api version, returns a message or not. Fixing that would allow me to have both version of the client work properly and handle real errors coming from bad server output)
Thanks for your time.