Add SetRawQueryString to preserve query parameter order#296
Draft
Add SetRawQueryString to preserve query parameter order#296
Conversation
Co-authored-by: parnurzeal <841616+parnurzeal@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Disable reordering of alphabetical query parameters
Add SetRawQueryString to preserve query parameter order
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query parameters are alphabetically sorted by
url.Values.Encode(), which breaks APIs requiring specific parameter ordering for signature generation.Changes
RawQueryStringfield toSuperAgentstructSetRawQueryString()method that bypassesurl.Values.Encode()sortingClone()andClearSuperAgent()to handle new fieldMakeRequest()to use raw query string when set (takes precedence overQueryData)Usage
Note: Pre-existing flaky
TestTimeoutFuncfailure is unrelated to these changes.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
http://github.com:80/parnurzeal/gorequest/tmp/go-build3060034973/b001/gorequest.test /tmp/go-build3060034973/b001/gorequest.test -test.paniconexit0 -test.v=true -test.count=1 -test.timeout=1m0s(http block)/tmp/go-build1464979024/b001/gorequest.test /tmp/go-build1464979024/b001/gorequest.test -test.paniconexit0 -test.v=true -test.count=1 -test.timeout=2m0s 0.1-go1.25.5.lin. 0.1-go1.25.5.lin-imultiarch rg/toolchain@v0.x86_64-linux-gnu(http block)/tmp/go-build1673557111/b001/gorequest.test /tmp/go-build1673557111/b001/gorequest.test -test.paniconexit0 -test.count=1 -test.timeout=2m0s(http block)www.google.com/tmp/go-build3060034973/b001/gorequest.test /tmp/go-build3060034973/b001/gorequest.test -test.paniconexit0 -test.v=true -test.count=1 -test.timeout=1m0s(dns block)/tmp/go-build1464979024/b001/gorequest.test /tmp/go-build1464979024/b001/gorequest.test -test.paniconexit0 -test.v=true -test.count=1 -test.timeout=2m0s 0.1-go1.25.5.lin. 0.1-go1.25.5.lin-imultiarch rg/toolchain@v0.x86_64-linux-gnu(dns block)/tmp/go-build1673557111/b001/gorequest.test /tmp/go-build1673557111/b001/gorequest.test -test.paniconexit0 -test.count=1 -test.timeout=2m0s(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.