Fix Json output name when export isn't set#337
Merged
parroty merged 1 commit intoparroty:masterfrom Jan 26, 2025
Merged
Conversation
timothyvanderaerden
changed the title
Owner
|
Thank you 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default
exportis set tofalse, with recent changes in #335 whenexportisn't set this results in thejsonbe named tofalse.json. This breaks pipelines that expect the filenameexcoveralls.jsonto be used.To be more precise, this is only when
export_coverageandpartitionsaren't also set as well, thenexportis set tofalse.See: https://github.com/elixir-lang/elixir/blob/029699735d8b3331316dd7362c5b3cfffe6f2602/lib/mix/lib/mix/tasks/test.ex#L578
And: https://github.com/elixir-lang/elixir/blob/029699735d8b3331316dd7362c5b3cfffe6f2602/lib/mix/lib/mix/tasks/test.ex#L582