Handle multiple types in coveralls.multiple when --umbrella is present#340
Open
pablocostass wants to merge 1 commit intoparroty:masterfrom
Open
Handle multiple types in coveralls.multiple when --umbrella is present#340pablocostass wants to merge 1 commit intoparroty:masterfrom
coveralls.multiple when --umbrella is present#340pablocostass wants to merge 1 commit intoparroty:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
--umbrellaflag isn't passed,excoverallsactually knows how to handle multiple types (it invokesExCoveralls.analyze/3for each of them), but if the option is present, then we handle the types as if it were only oneexcoveralls/lib/excoveralls.ex
Lines 61 to 69 in e9776c9
This results in a function clause error, which can be replicated in the umbrella example repo, https://github.com/parroty/excoveralls_umbrella
With the fix, however, one gets the following output