Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Jan 25, 2026

Pull Request

Issue

Fix failing WASM tests. The pubspec.lock is not tracked in git, so each CI run resolves fresh dependencies. A transitive dependency update between 2026-01-21 and 2026-01-23 likely broke WASM compatibility.

idb_shim 2.8.1 (released 2026-01-22) likely broke WASM test loading. It's a transitive dependency of sembast_web. The passing CI run (2026-01-21) got 2.8.0, the failing run (2026-01-23) got 2.8.1.

The idb_shim 2.8.1 release (2026-01-22) added "JDB implementation files from sembast_web". This appears to have introduced a regression that causes WASM tests to hang during initialization.

Summary by CodeRabbit

  • Tests
    • Updated Flutter test configuration to explicitly target the VM environment.
    • Added a new WASM compatibility smoke test to verify connectivity enum values are accessible across environments.

✏️ Tip: You can customize this high-level summary in your review settings.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 25, 2026

🚀 Thanks for opening this pull request!

@coderabbitai
Copy link

coderabbitai bot commented Jan 25, 2026

📝 Walkthrough

Walkthrough

Added VM test annotations and library directives to two existing Flutter test files, and introduced a new WASM compatibility smoke test verifying ParseConnectivityResult enum accessibility.

Changes

Cohort / File(s) Summary
Test File Metadata
packages/flutter/test/parse_client_configuration_test.dart, packages/flutter/test/parse_connectivity_implementation_test.dart
Added @TestOn('vm') annotation and library; directive at the top of each test file; no logic changes.
WASM compatibility test
packages/flutter/test/wasm_compatibility_test.dart
Added new smoke test asserting ParseConnectivityResult enum values (wifi, mobile, ethernet, none) are accessible in WASM environment.

Sequence Diagram(s)

(omitted — changes do not introduce multi-component control flow warranting a sequence diagram)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description identifies the issue clearly and explains the root cause but lacks structured sections matching the template. Add 'Approach' section explaining changes made (adding WASM compatibility test and VM-only annotations) and clearly mark completed tasks to follow the template structure.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'test: Fix failing WASM tests' directly summarizes the main change: addressing WASM test failures through test modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.37%. Comparing base (da03124) to head (fde7dc5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1110   +/-   ##
=======================================
  Coverage   44.37%   44.37%           
=======================================
  Files          62       62           
  Lines        3727     3727           
=======================================
  Hits         1654     1654           
  Misses       2073     2073           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai[bot]
coderabbitai bot previously approved these changes Jan 25, 2026
@mtrezza mtrezza changed the title test: Fix failing tests for platform plugins with native implementations that don't compile to WASM test: Fix failing WASM tests Jan 25, 2026
coderabbitai[bot]
coderabbitai bot previously approved these changes Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant