-
-
Notifications
You must be signed in to change notification settings - Fork 216
test: Fix failing WASM tests #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🚀 Thanks for opening this pull request! |
📝 WalkthroughWalkthroughAdded VM test annotations and library directives to two existing Flutter test files, and introduced a new WASM compatibility smoke test verifying Changes
Sequence Diagram(s)(omitted — changes do not introduce multi-component control flow warranting a sequence diagram) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1110 +/- ##
=======================================
Coverage 44.37% 44.37%
=======================================
Files 62 62
Lines 3727 3727
=======================================
Hits 1654 1654
Misses 2073 2073 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request
Issue
Fix failing WASM tests. The pubspec.lock is not tracked in git, so each CI run resolves fresh dependencies. A transitive dependency update between 2026-01-21 and 2026-01-23 likely broke WASM compatibility.
idb_shim 2.8.1 (released 2026-01-22) likely broke WASM test loading. It's a transitive dependency of sembast_web. The passing CI run (2026-01-21) got 2.8.0, the failing run (2026-01-23) got 2.8.1.
The idb_shim 2.8.1 release (2026-01-22) added "JDB implementation files from sembast_web". This appears to have introduced a regression that causes WASM tests to hang during initialization.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.