refactor: Upgrade puppeteer to 23.5.0 #2297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
abdullateef97
changed the title
abdullateef97
changed the title
mtrezza
changed the title
Member
|
There is some test refactor needed. |
Contributor
Author
|
@mtrezza please take a look again |
Member
|
Waiting for CI... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2297 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 61 64 +3
Lines 6186 6392 +206
Branches 1499 1524 +25
==========================================
+ Hits 6186 6392 +206 ☔ View full report in Codecov by Sentry. |
Member
|
I've reverted the package-lock file to v2. So we can do the lock-file upgrade to v3 in a separate PR at some point. |
Contributor
Author
ok cool, looks like the CI changes have passed |
Member
|
Thanks for the PR! |
Contributor
|
🎉 This change has been released in version 5.3.0-alpha.5 |
Contributor
|
🎉 This change has been released in version 6.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Issue
Closes: 2247
Approach
Upgrades the puppeteer version, this has been tested with node versions
18.20.4,20.15.1and22.4.1Tasks