Skip to content

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented Feb 20, 2025

Pull Request

Issue

Typescript instructions are missing.

Ref: #2012

Approach

  • Properly document how to build and test type definitions

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 20, 2025

🚀 Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3c13f69) to head (dc0c0bd).
Report is 16 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2463   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6244      6244           
  Branches      1452      1468   +16     
=========================================
  Hits          6244      6244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dplewis dplewis requested a review from a team February 20, 2025 19:39
@dplewis
Copy link
Member Author

dplewis commented Feb 24, 2025

@mtrezza How does this look? Feel free to change the verbiage

@mtrezza
Copy link
Member

mtrezza commented Mar 3, 2025

Does this require any changes, now that #2462 has been merged?

@dplewis
Copy link
Member Author

dplewis commented Mar 3, 2025

@mtrezza No changes needed.

@dplewis dplewis requested a review from mtrezza March 5, 2025 16:40
@mtrezza
Copy link
Member

mtrezza commented Mar 5, 2025

I believe I have seen some potential for improvement but didn't get around typing it up yet. On my list.

mtrezza
mtrezza previously approved these changes Mar 17, 2025
@mtrezza mtrezza changed the title docs: Add Typescript instructions to Contributing guide docs: Add TypeScript instructions and refactor Contributing guide Mar 17, 2025
@mtrezza mtrezza merged commit 16731e7 into parse-community:alpha Mar 17, 2025
10 checks passed
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 29, 2025
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants