Skip to content

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Mar 13, 2025

Pull Request

Issue

Don't need both module.exports and export default. We use export default for ES Module support

Approach

  • Change the way modules are imported in cjs tests (.default)

There is still one module.exports left (in Parse.ts). I left this for when we migrate from browserify to a modern build system like #2425.

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

parse-github-assistant bot commented Mar 13, 2025

🚀 Thanks for opening this pull request!

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (069740c) to head (cba9d85).
Report is 14 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2499   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6268      6244   -24     
  Branches      1456      1468   +12     
=========================================
- Hits          6268      6244   -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza changed the title refactor: Remove module.exports refactor: Remove module.exports Mar 16, 2025
@mtrezza mtrezza changed the title refactor: Remove module.exports refactor: Remove module.exports in favor of export default Mar 16, 2025
@mtrezza mtrezza merged commit 1dd1b1d into parse-community:alpha Mar 16, 2025
12 checks passed
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.3

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 16, 2025
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 17, 2025
@dplewis dplewis deleted the module-export branch May 18, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants