-
-
Notifications
You must be signed in to change notification settings - Fork 599
fix: Incorrect type in ParseObject.fetch
parameter options
#2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FetchOptions should be an optional parameter same as before the V6 changes. The ObjectController downstream already handles this parameter as optional.
🚀 Thanks for opening this pull request! |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #2726 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 6185 6185
Branches 1472 1460 -12
=========================================
Hits 6185 6185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ParseObject.fetch
parameter options
Could you please take a look at https://github.com/parse-community/Parse-SDK-JS/blob/alpha/CONTRIBUTING.md#typescript-tests for type modifications to fix the failing test. |
📝 WalkthroughWalkthroughMakes the ParseObject.fetch method’s options parameter optional in both implementation (src/ParseObject.ts) and type declarations (types/ParseObject.d.ts). No other logic or control flow changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
Sorry; didn't get to it. Reran types now. |
Hi, @mtrezza is this good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Pull Request
Issue
FetchOptions should be an optional parameter same as before the V6 changes. The ObjectController downstream already handles this parameter as optional.
Closes: #2725
Approach
Adds the optionality to the typescript type.
Tasks
Summary by CodeRabbit
New Features
TypeScript