Skip to content

refactor: Upgrade @aws-sdk/client-s3 from 3.779.0 to 3.787.0 #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor: Upgrade @aws-sdk/client-s3 from 3.779.0 to 3.787.0 #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
168 changes: 84 additions & 84 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"homepage": "https://github.com/parse-community/parse-server-s3-adapter#readme",
"dependencies": {
"@aws-sdk/client-s3": "3.779.0",
"@aws-sdk/client-s3": "3.787.0",
"@aws-sdk/s3-request-presigner": "3.758.0"
Comment on lines +22 to 23
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

❓ Verification inconclusive

Ensure version alignment between S3 client and presigner.

The @aws-sdk/s3-request-presigner remains at 3.758.0 while @aws-sdk/client-s3 was bumped to 3.787.0, which could introduce compatibility issues. Align both packages to the same version:

@@ -22,2 +22,2
-    "@aws-sdk/client-s3": "3.787.0",
-    "@aws-sdk/s3-request-presigner": "3.758.0"
+    "@aws-sdk/client-s3": "3.787.0",
+    "@aws-sdk/s3-request-presigner": "3.787.0"

Also regenerate your lockfile (package-lock.json or yarn.lock) and run the full test suite to catch any regressions.

Align @aws-sdk/s3-request-presigner version with @aws-sdk/client-s3

Ensure both AWS SDK packages use the same version to avoid compatibility issues.

• File: package.json (lines 22–23)

 "@aws-sdk/client-s3": "3.787.0",
-"@aws-sdk/s3-request-presigner": "3.758.0"
+"@aws-sdk/s3-request-presigner": "3.787.0"

After updating, regenerate your lockfile (package-lock.json or yarn.lock) and run the full test suite to catch any regressions.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"@aws-sdk/client-s3": "3.787.0",
"@aws-sdk/s3-request-presigner": "3.758.0"
"@aws-sdk/client-s3": "3.787.0",
"@aws-sdk/s3-request-presigner": "3.787.0"
🤖 Prompt for AI Agents (early access) 
In package.json at lines 22 to 23, the versions of @aws-sdk/client-s3 and @aws-sdk/s3-request-presigner are mismatched, which can cause compatibility issues. Update the version of @aws-sdk/s3-request-presigner to match the @aws-sdk/client-s3 version 3.787.0. After updating, regenerate your lockfile (package-lock.json or yarn.lock) and run the full test suite to ensure no regressions occur.

},
"devDependencies": {
Expand Down