Skip to content

Commit da1785c

Browse files
committed
fix: Added a loop in test to remove redundant code
1 parent ae26647 commit da1785c

File tree

1 file changed

+31
-45
lines changed

1 file changed

+31
-45
lines changed

spec/ParseUser.spec.js

Lines changed: 31 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -4447,55 +4447,41 @@ describe('custom log levels for username already exists error', () => {
44474447
infoSpy.calls.reset();
44484448
});
44494449

4450-
it('should respect warn log level for username already exists error', async () => {
4451-
await reconfigureServer({
4452-
logLevels: {
4453-
usernameAlreadyExists: 'warn',
4454-
},
4455-
});
4450+
const testCases = [
4451+
{ logLevel: 'warn', expectedSpy: 'warnSpy' },
4452+
{ logLevel: 'info', expectedSpy: 'infoSpy' },
4453+
];
4454+
4455+
testCases.forEach(({ logLevel, expectedSpy }) => {
4456+
it(`should respect ${logLevel} log level for username already exists error`, async () => {
4457+
await reconfigureServer({
4458+
logLevels: {
4459+
usernameAlreadyExists: logLevel,
4460+
},
4461+
});
44564462

4457-
const user = new Parse.User();
4458-
user.setUsername('existingUser');
4459-
user.setPassword('password');
4460-
await user.signUp();
4463+
const username = `existingUser_${logLevel}`;
44614464

4462-
const duplicateUser = new Parse.User();
4463-
duplicateUser.setUsername('existingUser');
4464-
duplicateUser.setPassword('password');
4465+
const user = new Parse.User();
4466+
user.setUsername(username);
4467+
user.setPassword('password');
4468+
await user.signUp();
44654469

4466-
try {
4467-
await duplicateUser.signUp();
4468-
} catch (error) {
4469-
expect(error.code).toBe(Parse.Error.USERNAME_TAKEN);
4470-
expect(warnSpy).toHaveBeenCalled();
4471-
expect(errorSpy).not.toHaveBeenCalled();
4472-
expect(infoSpy).not.toHaveBeenCalled();
4473-
}
4474-
});
4470+
const duplicateUser = new Parse.User();
4471+
duplicateUser.setUsername(username);
4472+
duplicateUser.setPassword('password');
44754473

4476-
it('should respect info log level for username already exists error', async () => {
4477-
await reconfigureServer({
4478-
logLevels: {
4479-
usernameAlreadyExists: 'info',
4480-
},
4474+
try {
4475+
await duplicateUser.signUp();
4476+
} catch (error) {
4477+
expect(error.code).toBe(Parse.Error.USERNAME_TAKEN);
4478+
expect(this[expectedSpy]).toHaveBeenCalled();
4479+
['warnSpy', 'errorSpy', 'infoSpy'].forEach(spy => {
4480+
if (spy !== expectedSpy) {
4481+
expect(this[spy]).not.toHaveBeenCalled();
4482+
}
4483+
});
4484+
}
44814485
});
4482-
4483-
const user = new Parse.User();
4484-
user.setUsername('anotherExistingUser');
4485-
user.setPassword('password');
4486-
await user.signUp();
4487-
4488-
const duplicateUser = new Parse.User();
4489-
duplicateUser.setUsername('anotherExistingUser');
4490-
duplicateUser.setPassword('password');
4491-
4492-
try {
4493-
await duplicateUser.signUp();
4494-
} catch (error) {
4495-
expect(error.code).toBe(Parse.Error.USERNAME_TAKEN);
4496-
expect(infoSpy).toHaveBeenCalled();
4497-
expect(warnSpy).not.toHaveBeenCalled();
4498-
expect(errorSpy).not.toHaveBeenCalled();
4499-
}
45004486
});
45014487
});

0 commit comments

Comments
 (0)