-
-
Notifications
You must be signed in to change notification settings - Fork 149
feat: audit logging #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: audit logging #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12627709898Details
💛 - Coveralls |
hippalus
reviewed
Jan 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Few comments
proposed format:
|
parmesant
pushed a commit
to parmesant/parseable
that referenced
this pull request
Jan 13, 2025
Add remote audit logging with the below schema: ``` { "parseable_server_version": "1.6.3", "parseable_server_deploymentId": "01JGR7PS9K28JRKNS4V6F2WNAK", "audit_version": "V1", "audit_generation_timestamp": "2025-01-04T14:16:28.483+05:30", "audit_id": "01JGR7X443QX5N45B4ZPNN5QEG", "actor_authorizationMethod": "Basic Auth", "actor_remote_host": "127.0.0.1", "actor_username": "admin", "actor_user_agent": "PostmanRuntime/7.43.0", "request_headers_accept": "*/*", "request_headers_accept-encoding": "gzip, deflate, br", "request_headers_connection": "keep-alive", "request_headers_content-length": "100", "request_headers_content-type": "application/json", "request_headers_host": "localhost:8000", "request_headers_postman-token": "6a1bd4ae-0395-4e5c-90df-b7b5105bf0b5", "request_method": "POST", "request_start_time": "2025-01-04T14:16:28.480+05:30", "request_end_time": "2025-01-04T14:16:28.483+05:30", "request_path": "/api/v1/ingest", "request_protocol": "http", "request_body_size": "1234", "response_status_code": 400, "response_error_message": "", "response_body_size": "1234", "stream": "app", } ``` Fixes parseablehq#765 --------- Signed-off-by: Devdutt Shenoi <[email protected]> Co-authored-by: Nikhil Sinha <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #765.
Description
Audit logs are sent to another Parseable instance everytime a request is received over http or when new logs are received over kafka.
While we did explore the option, we chose to perform audit logging without relying on tracing, given the complexity of the setup.
In the PR we have been as careful as possible to not cause unnecessary allocations if we don't end up logging anyways.
This PR has: