Skip to content

feat: trino is no longer supported as a query engine #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2025
Merged

feat: trino is no longer supported as a query engine #1077

merged 2 commits into from
Jan 7, 2025

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 7, 2025

Fixes #XXXX.

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 7, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12646273704

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 12.043%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/about.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/handlers/http/modal/server.rs 1 0.0%
Totals Coverage Status
Change from base Build 12637433276: 0.1%
Covered Lines: 2356
Relevant Lines: 19563
💛 - Coveralls

@de-sh de-sh marked this pull request as ready for review January 7, 2025 06:27
nikhilsinhaparseable
nikhilsinhaparseable approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit b46be32 into parseablehq:main Jan 7, 2025
9 checks passed
@de-sh de-sh deleted the rm-trino branch January 9, 2025 09:58
parmesant pushed a commit to parmesant/parseable that referenced this pull request Jan 13, 2025
@parmesant
feat: trino is no longer supported as a query engine (parseablehq#1077)
6e4784e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilsinhaparseable nikhilsinhaparseable nikhilsinhaparseable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@de-sh @coveralls @nikhilsinhaparseable @nitisht