refactor: return an explicit error for unrecognized data types in static schema

[sainad2222]

Fixes #1223

Description

1. Add new error type for unrecognized data types and logic to handle it
2. Add unit test for this change

This PR has:

• been tested to ensure log ingestion and log query works.
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added documentation for new or modified features or behaviors.

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling for unrecognized data types by providing a clear error message when an unknown type is encountered.

• Tests

  • Added a test case to verify that unknown data types produce the appropriate error message.

[coderabbitai]

Walkthrough

The function handling static schema conversion now returns a specific error (StaticSchemaError::UnrecognizedDataType) when encountering unrecognized data types, instead of defaulting to DataType::Null. The error variant was added to the error enum, and a test was introduced to ensure the new error is correctly triggered and contains the problematic type string.

Changes

Cohort / File(s)	Change Summary
Error handling for unrecognized data types src/static_schema.rs	Replaced fallback to DataType::Null with an explicit error (StaticSchemaError::UnrecognizedDataType). Added the new error variant to the enum and implemented a test to verify this behavior.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant convert_static_schema_to_arrow_schema
    participant StaticSchemaError

    Caller->>convert_static_schema_to_arrow_schema: Call with static schema
    convert_static_schema_to_arrow_schema->>convert_static_schema_to_arrow_schema: Iterate fields
    alt Recognized data type
        convert_static_schema_to_arrow_schema-->>Caller: Return Arrow schema
    else Unrecognized data type
        convert_static_schema_to_arrow_schema->>StaticSchemaError: Create UnrecognizedDataType error
        StaticSchemaError-->>convert_static_schema_to_arrow_schema: Return error
        convert_static_schema_to_arrow_schema-->>Caller: Return UnrecognizedDataType error
    end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Explicitly return an error for unrecognized data types instead of defaulting to null (#1223)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Poem

A schema once tripped on a type it knew not,
But now it shouts, “Error!”—no secrets forgot.
No longer does “null” quietly sweep,
Each oddball type gets a message to keep.
With tests in the warren, all rabbits agree:
“Explicit is best!”—so hoppy are we! 🐇✨

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d9548fa and 7429f7e.

📒 Files selected for processing (1)

• src/static_schema.rs (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/static_schema.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

• GitHub Check: Build Default x86_64-pc-windows-msvc
• GitHub Check: Build Default x86_64-apple-darwin
• GitHub Check: Build Default x86_64-unknown-linux-gnu
• GitHub Check: Build Default aarch64-apple-darwin
• GitHub Check: Build Kafka aarch64-apple-darwin
• GitHub Check: Build Default aarch64-unknown-linux-gnu
• GitHub Check: Build Kafka x86_64-unknown-linux-gnu
• GitHub Check: Quest Smoke and Load Tests for Distributed deployments
• GitHub Check: Quest Smoke and Load Tests for Standalone deployments
• GitHub Check: coverage

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[sainad2222]

I have read the CLA Document and I hereby sign the CLA