-
-
Notifications
You must be signed in to change notification settings - Fork 150
chore: update cargo toml for release v2.4.1 #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughBumped package version to 2.4.1 in Cargo.toml and updated parseable_ui asset URL and SHA-1 checksum in both metadata blocks to point to v2.4.1 assets. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Cargo.toml (1)
160-161
: Consider migrating asset integrity to SHA-256 (future-proofing)SHA-1 is collision-prone. If feasible in a future release, consider switching to SHA-256 (and updating build.rs or wherever this is validated). The repo already depends on sha2, so adding sha2 as a build-dependency could simplify the change.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
- GitHub Check: Build Kafka aarch64-apple-darwin
- GitHub Check: Build Default x86_64-apple-darwin
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
- GitHub Check: coverage
🔇 Additional comments (1)
Cargo.toml (1)
160-161
: Manual Verification: UI Asset URL and Checksum
- Confirm the URL in Cargo.toml (line 160) is reachable and returns HTTP 200.
- Download the asset and compute its SHA-1 checksum; ensure it matches the value on line 161 (
19eec4d38b978270eca1026325350e38c235ac31
).- Verify there are no other
[package.metadata.parseable_ui]
blocks pointing to older versions elsewhere in the repository.
@@ -1,6 +1,6 @@ | |||
[package] | |||
name = "parseable" | |||
version = "2.4.0" | |||
version = "2.4.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Version bump to 2.4.1 — LGTM
Looks consistent with the PR objective. No functional concerns on this line.
If this is a workspace or there are other manifests, quickly verify no stale 2.4.0 references remain:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Find any lingering references to v2.4.0 in manifests or docs
rg -n --hidden -S 'v2\.4\.0|version\s*=\s*"2\.4\.0"'
Length of output: 187
Stale 2.4.0
references found – please update to 2.4.1
The version bump in Cargo.toml
is correct, but there are still outdated references in other manifests:
- index.yaml (line 36):
changeappVersion: v2.4.0
→appVersion: v2.4.1
- helm/Chart.yaml (line 6):
changeappVersion: "v2.4.0"
→appVersion: "v2.4.1"
- helm/values.yaml (line 4):
changetag: "v2.4.0"
→tag: "v2.4.1"
Suggested diff:
index.yaml | 1 line
- appVersion: v2.4.0
+ appVersion: v2.4.1
helm/Chart.yaml | 1 line
-appVersion: "v2.4.0"
+appVersion: "v2.4.1"
helm/values.yaml | 1 line
- tag: "v2.4.0"
+ tag: "v2.4.1"
Once these are updated, the version bump will be fully consistent across the repo.
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In Cargo.toml around line 3, version has been bumped to 2.4.1 but other
manifests still reference 2.4.0; update index.yaml (line 36) changing
appVersion: v2.4.0 → appVersion: v2.4.1, update helm/Chart.yaml (line 6)
changing appVersion: "v2.4.0" → appVersion: "v2.4.1", and update
helm/values.yaml (line 4) changing tag: "v2.4.0" → tag: "v2.4.1" so all version
references are consistent.
Summary by CodeRabbit