Conversation
lroberts36
approved these changes
Dec 22, 2025
Collaborator
lroberts36
left a comment
lroberts36
left a comment
There was a problem hiding this comment.
This LGTM, only one real comment below.
| It is often convenient to hold multiple pools, one for each different | ||
| size of object that we might want to pool. (For example for | ||
| differently shaped comm buffers.) We implement that via the | ||
| ``ObjectPoolMap<T>`` type, which owns an arbitrary number of |
Collaborator
There was a problem hiding this comment.
Have you considered ObjectWaterPark<T>?
Collaborator
Author
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
@swjones and I are going to use @lroberts36 object pools for more things and I found that the map of pools based on shapes is a useful construct, so I am factoring it out of mesh so I can reuse it. This small MR does that.
PR Checklist