WIP: Generalize multigrid hierarchy#1363
Open
lroberts36 wants to merge 32 commits intolroberts36/solver-speedup-restrictfrom
Open
WIP: Generalize multigrid hierarchy#1363lroberts36 wants to merge 32 commits intolroberts36/solver-speedup-restrictfrom
lroberts36 wants to merge 32 commits intolroberts36/solver-speedup-restrictfrom
Conversation
…peedup-integration
…ver-speedup-integration
…olver-speedup-integration
…-speedup-integration
Collaborator
|
since this depends on all those other MRs... the diff is hard to read. I think I'll wait to review until those are in |
Collaborator
Author
@Yurlungur: Yeah, no need to review while it is in WIP. I am still working on it and I put it up mostly because I wanted to easily be able to see the diff. |
This reverts commit f8738e9.
…tigrid-reduce-block-size-first
lroberts36
commented
Jan 26, 2026
|
|
||
| MeshData<Real> mesh_data("base"); | ||
| mesh_data.Initialize(block_list, nullptr, NDIM); | ||
| mesh_data.Initialize(block_list, nullptr); |
Collaborator
Author
There was a problem hiding this comment.
This was just a previously existing bug where the NDIM being passed here was assumed to be the multigrid level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Generalizes the geometric multigrid (GMG) hierarchy to support an initial
sequence of leaf-only GMG grids before transitioning to two-level
composite grids, rather than forcing an immediate move to composite grids.
Introduces a new runtime parameter
parthenon/mesh/base_block_coarseningswhich controls how many leaf GMG grids (with increasing in-block coarsening) are
included at the start of the hierarchy.
Refactors GMG grid identification to explicitly track:
leafvstwo_level_composite),block_coarsenings),Preserves and clarifies two-level composite grid semantics, where a composite
grid at logical level ℓ includes:
Updates GMG hierarchy construction logic to cleanly separate:
Extends boundary communication infrastructure to allow multiple
communication buffers per communication channel, enabling concurrent
communication on multiple
MeshDatastages without MPI lock contention.tag_map.*,bvals_utils.hpp,mesh_data.hpp, andbuild_boundary_buffers.cpp.TODO before removing WIP
Update coalesced communication infrastructure to correctly handle the new
“multiple buffers per communication channel” capability.
Add a more extensive solver testing infrastructure for GMG-based solvers.
Add or update documentation describing:
parthenon/mesh/base_block_coarseningsparameter,PR Checklist