Skip to content

Pin homebrew hdf5-mpi#1366

Merged
Yurlungur merged 3 commits intodevelopfrom
acreyes/hdf5-macos-ci
Feb 23, 2026
Merged

Pin homebrew hdf5-mpi#1366
Yurlungur merged 3 commits intodevelopfrom
acreyes/hdf5-macos-ci

Conversation

@acreyes
Copy link
Collaborator

@acreyes acreyes commented Feb 20, 2026

PR Summary

Workaround for issue with cmake's FindHDF5 and hdf5 2.0.0 in the mac os CI. This should get all fixed in cmake 4.3 and then this can get reverted.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting in this one-liner!

@Yurlungur Yurlungur self-assigned this Feb 20, 2026
@Yurlungur
Copy link
Collaborator

@pdmullen @lroberts36 this needs one more review

@Yurlungur
Copy link
Collaborator

And it's pretty urgent this go in, so that the other MRs caught on this CI issue can get merged.

@Yurlungur Yurlungur enabled auto-merge February 20, 2026 17:29
@Yurlungur Yurlungur merged commit 94e5ac4 into develop Feb 23, 2026
38 checks passed
@Yurlungur Yurlungur deleted the acreyes/hdf5-macos-ci branch February 23, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants