Conversation
Yurlungur
approved these changes
Feb 20, 2026
Collaborator
Yurlungur
left a comment
There was a problem hiding this comment.
Thanks for putting in this one-liner!
Collaborator
|
@pdmullen @lroberts36 this needs one more review |
Collaborator
|
And it's pretty urgent this go in, so that the other MRs caught on this CI issue can get merged. |
pdmullen
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Workaround for issue with cmake's FindHDF5 and hdf5 2.0.0 in the mac os CI. This should get all fixed in cmake 4.3 and then this can get reverted.
PR Checklist