Skip to content

Updates to #1365#1367

Merged
lroberts36 merged 8 commits intodempsey/bvalsfrom
lroberts36/update-dempsey/bvals
Feb 24, 2026
Merged

Updates to #1365#1367
lroberts36 merged 8 commits intodempsey/bvalsfrom
lroberts36/update-dempsey/bvals

Conversation

@lroberts36
Copy link
Collaborator

@lroberts36 lroberts36 commented Feb 24, 2026

PR Summary

Original PR #1365

  • Don't call boundary conditions on the coarse buffer if there are no coarser neighbors to fill it
  • This is a correctness fix, not an optimization

Additions

  1. Added HasCoarserNeighbors() method

    • Cleaner way to check if a block has coarser neighbors
    • Used in boundary_conditions.cpp and bnd_info.cpp where we were doing this check manually
  2. Fixed uninitialized variables

    • Initialized all the uninitialized MeshBlock members:
      • gid, lid, cnghost, gflag
      • new_block_dt_, new_block_dt_hyperbolic_, new_block_dt_parabolic_
      • cost_, mem_usage_
    • Not really related to this PR, but good excuse to do it
  3. Made neighbor vectors private

    • Neighbor lists now have public getters but can only be set through SetMeshBlockNeighbors()
    • Prevents accidental modification
    • Used vscode Continue + Claude-4.5 for this refactor, which was fairly efficient

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@lroberts36 lroberts36 changed the title Updates to #1365 WIP: Updates to #1365 Feb 24, 2026
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up.


} // namespace parthenon

#endif // MESH_MESH_NEIGHBORS_HPP_ No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

@adamdempsey90
Copy link
Collaborator

WIP?

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog and remove WIP

@lroberts36 lroberts36 changed the title WIP: Updates to #1365 Updates to #1365 Feb 24, 2026
@lroberts36 lroberts36 merged commit e5d8906 into dempsey/bvals Feb 24, 2026
11 checks passed
@lroberts36 lroberts36 deleted the lroberts36/update-dempsey/bvals branch February 24, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants