Replace partial MiniFoundation with FoundationEssentials#307
Merged
Replace partial MiniFoundation with FoundationEssentials#307
Conversation
Export Foundation on Apple, and FoundationEssentials everywhere else. In the latter case, add some custom code behind the MINIF_COMPAT symbol to attain feature-parity with Foundation for the sake of the library. Steps: - Delete SWON, rely on Codable/JSONEncoder/JSONDecoder - Delete redundant compat entities (Data, Date, URL, UUID) - Delete unused C code - Returns contents of path, not generic URL (requires networking) - Always export Dispatch - Disambiguate UUID on Windows
Prepend FoundationEssentials just in case
Member
Author
|
Doubts:
Are these methods equivalent?
public func contentsOfDirectory(at url: URL) throws -> [URL] {
let items = try contentsOfDirectory(atPath: url.filePath())
return items.map {
URL(filePath: $0, relativeTo: url)
}
}
Specifically:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give up on the overwhelming –and dumb– task of replacing Foundation completely. The footprint with FoundationEssentials is only marginally bigger, for dramatic benefits. If going serious at some point, dropping Swift would be a much wiser choice in the future.
Basically, merge MiniFoundation Native and Compat targets. Then export Foundation on Apple, and FoundationEssentials everywhere else. In the latter case, add some custom code behind the MINIF_COMPAT symbol to attain feature-parity with Foundation for the sake of the library.
MiniFoundation folders:
Steps:
CMake issues: