Skip to content

Fix asset-hub-paseo build errors for staking rc-client v0.7.3#345

Merged
tsenovilla merged 1 commit intomainfrom
fix/ci-staking-build-errors
Mar 23, 2026
Merged

Fix asset-hub-paseo build errors for staking rc-client v0.7.3#345
tsenovilla merged 1 commit intomainfrom
fix/ci-staking-build-errors

Conversation

@al3mart
Copy link
Copy Markdown
Member

@al3mart al3mart commented Mar 23, 2026

Summary

The Create Runtimes Release CI workflow fails when building asset-hub-paseo-runtime due to three compilation errors introduced by the upgrade to pallet-staking-async-rc-client v0.7.3. This PR fixes all three:

  • #[derive(MaxEncodedLen)] on SessionKeys — The KeyDeposit parameter calls SessionKeys::max_encoded_len(), but impl_opaque_keys! does not derive MaxEncodedLen by default. Adding the derive attribute resolves.

  • Replace polkadot_runtime_constants with paseo_runtime_constants — The staking module referenced polkadot_runtime_constants::currency::deposit(), but that crate was never added as a dependency. paseo_runtime_constants is already available in the workspace and provides the same deposit() function.

  • Add type Currency = Balances to pallet_staking_async_rc_client::Config — The Currency associated type was added in rc-client v0.7.3 (it was not required in v0.7.0).

All three fixes align with how the upstream Polkadot Fellows runtimes configure the same pallets for asset-hub-polkadot.

Test plan

  • cargo check -p asset-hub-paseo-runtime passes locally
  • CI Create Runtimes Release workflow passes

…0.7.3

- Add #[derive(MaxEncodedLen)] to SessionKeys so max_encoded_len() is available
- Replace unlinked polkadot_runtime_constants with paseo_runtime_constants
- Add missing type Currency = Balances to rc_client Config impl
@al3mart al3mart requested a review from tsenovilla March 23, 2026 10:07
@tsenovilla tsenovilla merged commit 5308f34 into main Mar 23, 2026
1 check passed
@tsenovilla tsenovilla deleted the fix/ci-staking-build-errors branch March 23, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants