Fix asset-hub-paseo build errors for staking rc-client v0.7.3#345
Merged
tsenovilla merged 1 commit intomainfrom Mar 23, 2026
Merged
Fix asset-hub-paseo build errors for staking rc-client v0.7.3#345tsenovilla merged 1 commit intomainfrom
tsenovilla merged 1 commit intomainfrom
Conversation
…0.7.3 - Add #[derive(MaxEncodedLen)] to SessionKeys so max_encoded_len() is available - Replace unlinked polkadot_runtime_constants with paseo_runtime_constants - Add missing type Currency = Balances to rc_client Config impl
tsenovilla
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Create Runtimes ReleaseCI workflow fails when buildingasset-hub-paseo-runtimedue to three compilation errors introduced by the upgrade topallet-staking-async-rc-clientv0.7.3. This PR fixes all three:#[derive(MaxEncodedLen)]onSessionKeys— TheKeyDepositparameter callsSessionKeys::max_encoded_len(), butimpl_opaque_keys!does not deriveMaxEncodedLenby default. Adding the derive attribute resolves.Replace
polkadot_runtime_constantswithpaseo_runtime_constants— The staking module referencedpolkadot_runtime_constants::currency::deposit(), but that crate was never added as a dependency.paseo_runtime_constantsis already available in the workspace and provides the samedeposit()function.Add
type Currency = Balancestopallet_staking_async_rc_client::Config— TheCurrencyassociated type was added in rc-client v0.7.3 (it was not required in v0.7.0).All three fixes align with how the upstream Polkadot Fellows runtimes configure the same pallets for asset-hub-polkadot.
Test plan
cargo check -p asset-hub-paseo-runtimepasses locallyCreate Runtimes Releaseworkflow passes