PB-47870 - Redesign go cli release workflow#117
Draft
cedricherzog-passbolt wants to merge 1 commit intopassbolt:mainfrom
Draft
PB-47870 - Redesign go cli release workflow#117cedricherzog-passbolt wants to merge 1 commit intopassbolt:mainfrom
cedricherzog-passbolt wants to merge 1 commit intopassbolt:mainfrom
Conversation
Signed-off-by: cedricherzog-passbolt <cedric.herzog@passbolt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
GoReleaser simultaneously creates a draft GitHub Release AND updates the Homebrew tap formula when a tag is pushed. Draft releases don't serve artifacts publicly, so brew upgrade users get 404 errors until a maintainer manually publishes the release.
Root cause:
go-passbolt-cli/.goreleaser.yml:24: draft: true — release is created as draftgo-passbolt-cli/.goreleaser.yml:49: skip_upload: false — Homebrew tap is updated immediately (the bug)go-passbolt-cli/.github/workflows/.release.yml:5: trigger is tag: '*' (too broad — catches non-version tags)Solution:
Two-workflow split. The spec provided is correct. Notes below capture one gap and confirm the rest.