fix: selected text inside the active line was invisible#826
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes issue #803 where selected text inside the active line was invisible in CodeMirror editors. The fix involves modifying all 8 CodeMirror theme files to adjust z-index layering and selection colors, plus removing conflicting hover styles from the Editor component.
Changes:
- Added
position: "relative"andzIndex: -3to.cm-activeLinein all theme files to push the active line background behind selection highlights - Updated selection background colors in all themes to use more visible, semi-transparent colors
- Fixed a typo in dracula.ts selector (removed extra 'm' in
.cm-selectionBackground) - Removed background-color hover effects from Editor.svelte that could interfere with the new z-index layering
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| client/src/lib/codemirror-themes/solarized.ts | Applied z-index fix to active line, updated selection colors, removed unused selection variable |
| client/src/lib/codemirror-themes/rose-pine.ts | Applied z-index fix to active line, updated selection colors to semi-transparent |
| client/src/lib/codemirror-themes/rose-pine-dawn.ts | Applied z-index fix to active line, updated selection colors to semi-transparent |
| client/src/lib/codemirror-themes/myst.ts | Applied z-index fix to active line, updated selection colors, removed unused sel variable |
| client/src/lib/codemirror-themes/myst-light.ts | Applied z-index fix to active line, updated selection colors, removed unused sel variable |
| client/src/lib/codemirror-themes/dracula.ts | Applied z-index fix to active line, updated selection colors, fixed selector typo, removed unused selection variable |
| client/src/lib/codemirror-themes/catppuccin.ts | Applied z-index fix to active line, updated selection colors to semi-transparent |
| client/src/lib/codemirror-themes/catppuccin-late.ts | Applied z-index fix to active line, updated selection colors to semi-transparent |
| client/src/lib/Editor.svelte | Removed background-color hover effects that could conflict with theme z-index layering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #803