feat: Selective abstract eval #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CLA signatures confirmedAll contributors have signed the Contributor License Agreement. |
Contributor
Author
|
@PasteurBot I have read the CLA Document and I hereby sign the CLA |
andrinr
requested review from
apaleyes,
dionhaefner and
xalelax
as code owners
xalelax
reviewed
Sep 18, 2025
Contributor
xalelax
left a comment
xalelax
left a comment
There was a problem hiding this comment.
Good for now 👍 only minor edits suggested.
xalelax
approved these changes
Sep 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue or PR
Tesseract need to have an abstract eval defined, even if jax would not require them to.
Description of changes
This PR avoids calls to abstract_eval if it is not defined in the Tesseract API. If a function transformation is applied without the abstract eval, an error is raised.
Furthermore we add a concrete implementation "tesseract_dispatch()" that does not rely on any function transformations.
Testing done
added new tests