fix: Adapt version of vectoradd_jax to new Tesseract conventions #86
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Just curious, have you actually run the things that fails on main, to make sure the fix works? I am guessing it is not triggered by the CI. |
Contributor
Author
I did, locally I was able to run the |
apaleyes
approved these changes
Sep 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue or PR
A job on main fails https://github.com/pasteurlabs/tesseract-jax/actions/runs/17833574910/job/50704738666#step:8:132
Description of changes
removed the version previously being used, which is incompatible with tesseract >=1.0.0 conventions