Ignore symbolic links when loading directories

[matthewmcgarvey]

Fixes #74

The only difference between statSync and lstatSync is that the latter handles symbolic links while the former causes an error. Then we can ignore symbolic links.

https://nodejs.org/api/fs.html#fslstatpath-options-callback

[devo-wm]

Confirming this changes resolved my issue as well! Would love to get this merged in :)

[patbenatar]

@matthewmcgarvey Thanks for the fix! Sorry for my delay in getting to this -- I don't have much time to support this plugin these days. I've gone ahead and given you push access to this repo if you're interested in helping maintain it.

It'd be great if we could add test coverage for this change. I started down that path but realized I haven't run the development environment for this project in a long time and looks like things have changed wrt how VS Code extensions are tested (https://code.visualstudio.com/api/working-with-extensions/testing-extension#migrating-from-vscode).

[matthewmcgarvey]

@patbenatar Appreciate it! I'll try to figure out the testing thing

[jwinters01]

Hello! Would love to get this fix in. Is there anything I can do to move this along? What's preventing it from being merged?

[patbenatar]

@jwinters01 thanks for your interest in helping! The delay here is because I don't really maintain this repo anymore (I still use it everyday but it's been good enough ha), I don't even have a dev env setup for extensions these days.

If I add you as a collaborate on the repo and the plugin do you want to take over this feature (test, merge, release)?

[jwinters01]

Sure I'd be happy to 👍

[jwinters01]

Hello 👋 I opened this PR to update how tests are executed in this Repo: #133 @patbenatar if you can add me as a collaborator I can get these changes in and get this fix merged with some testing

[patbenatar]

@jwinters01 just added you as a collaborator, thank you!

[patbenatar]

@jwinters01 will you also send me your VS Code Marketplace user ID so I can add you as a collaborator there for publishing?

[jwinters01]

my user ID is 7a97d02f-daac-65e4-8807-512a3cbcdfe4, hope that's what you need

[patbenatar]

@jwinters01 thanks, added!

[matthewmcgarvey]

It's funny looking back at this. I have no idea why I didn't follow up on the tests almost 4 years ago. But I can say that I definitely still use this extension regularly (I set up a new vscode install recently and tried going without it and I just couldn't do it). Big thanks to you, patbenatar, for making this extension!

[patbenatar]

Haha thanks. Life happens, it's all good. I also still use this everyday and while there's definitely room for improvement it continues to get the job done 👌