PatchWork AutoFix

[CTY-git]

This pull request from patched fixes 23 issues.

---

• File changed: WebContent/swagger/lib/marked.js
  Refactored code to prevent potential ReDoS vulnerabilities in RegExp()

  Hardcoded the regex variable and added a condition to validate the opt argument. This ensures that the updated RegExp is not user-controlled to minimize the risk of ReDos attacks.
  Fixed potential ReDoS vulnerability in RegExp function call

  Replaced the function call that generated a regular expression using a concatentated string, with a hardcoded regular expression. This is to fix a potential Regular Expression Denial-of-Service (ReDoS) vulnerability.

• File changed: src/com/ibm/security/appscan/altoromutual/util/DBUtil.java
  Fix SQL Injection Vulnerability in storeFeedback Method

  Replaced usage of the 'java.sql.Statement' with 'java.sql.PreparedStatement' to prevent potential SQL Injection attacks. The input variables are now safely passed to the SQL command via placeholders, thereby avoiding vulnerability.
  Fixed potential SQL injection vulnerability.

  Replaced usage of Statement with PreparedStatement to prevent any possible SQL injection attacks through the use of parameterized queries.
  Fix SQL Injection Vulnerability

  Replaced the Statement with PreparedStatement to prevent SQL Injection attacks as the SQL code has now been separated from the data variables.
  Switch to PreparedStatement to avoid SQL Injection risks

  Changed the implementation of the "addSpecialUser" method. Instead of using a Statement for executing SQL commands with unvalidated Strings which could lead to SQL Injection, it's now switched to PreparedStatement to sanitize variables inserted into SQL statements.
  Fixed potential SQL injection vulnerability by using PreparedStatement.

  Replaced usage of Statement object with PreparedStatement to prevent SQL injection vulnerabilities. Input variables are now inserted into the SQL query using setString, ensuring they're properly sanitized.
  Fixed potential SQL injection vulnerability by using PreparedStatement.

  Replaced Statement with PreparedStatement to prevent potential SQL injection. Parameters are now safely added to SQL query with setLong, improving security.
  Replace Statement with PreparedStatement to prevent SQL injection.

  Replaced all instances of java.sql.Statement with java.sql.PreparedStatement. Used parameter binding to protect against SQL injection.
  Fixed SQL Injection vulnerability using Prepared Statements

  Replaced the SQL statements in the code with java.sql.PreparedStatement to avoid SQL Injection vulnerability due to un-sanitized SQL queries.
  Prepared statement use to prevent SQL injection.

  Changed code to use PreparedStatement instead of Statement. This prevents the possibility of SQL Injection attacks, since we're no longer concatenating user-provided strings to form SQL queries.
  Fixed SQL injection vulnerability using PreparedStatement

  Replaced java.sql.Statement with java.sql.PreparedStatement to sanitize the user input. The code now creates a PreparedStatement using connection.prepareStatement() method where '?' acts as a placeholder for the username. The username is then set using the PreparedStatement.setString() method, which ensures that any special characters in the username are properly escaped, greatly reducing the risk of SQL injection.
  Fix potential SQL Injection vulnerability by replacing Statement with PreparedStatement

  Replaced the SQL Statement object with a PreparedStatement. A PreparedStatement allows us to write a SQL statement and then fill in the parameterized values later, which effectively prevents SQL Injection attacks by correctly escaping the parameters.

• File changed: src/com/ibm/security/appscan/altoromutual/util/ServletUtil.java
  Set Secure Flag on Session Cookies

  Added setSecure method call on accountCookie object to make sure the cookie is sent only over HTTPS.

• File changed: WebContent/high_yield_investments.htm
  Updated plaintext URL to HTTPS

  Replaced the HTTP URL with its HTTPS version

• File changed: src/com/ibm/security/appscan/altoromutual/servlet/SurveyServlet.java
  Sanitize user-provided content to prevent XSS

  User-provided content is now sanitized before it is written to the response writer. This is done using the ESAPI library's encodeForHTML method, which replaces potentially dangerous characters with their html-escaped equivalents.
  Sanitize user-inputted step before setting session attribute

  Added a simple checking function named sanitizeInput to sanitize the user input to mitigate trust boundary violation issue. User-inputted step is checked and cleaned before being used to set a session attribute.

• File changed: WebContent/static/security.htm
  Change plaintext HTTP URL to encrypted HTTPS URL.

  Replaced "http" in the URL with "https" to secure the connection.

• File changed: src/com/ibm/security/appscan/altoromutual/util/OperationsUtil.java
  Replaced java.util.Random with java.security.SecureRandom for cryptographically strong random string generation

  Replaced java.util.Random in the method makeRandomString with java.security.SecureRandom for generating the random string. This is more secure and recommended for applications that require high-value security and protection against potential attacks to guess the generated string.

• File changed: WebContent/static/inside_about.htm
  Changed plaintext HTTP link to HTTPS for increased security.

  The plaintext HTTP link has been changed to its HTTPS version to prevent any unencrypted communication which could be vulnerable to attacks.

• File changed: WebContent/static/inside_community.htm
  Secure External Link to Adobe Reader

  Replaced the plaintext HTTP URL for Adobe Reader with an encrypted HTTPS URL.

• File changed: src/com/ibm/security/appscan/altoromutual/servlet/AdminServlet.java
  Fixed a trust boundary violation vulnerability by sanitizing user input before passing it to the session attribute.

  Entrusted the user input by adding HTML escape utility before setting the message variable to the session attribute. This ensures that no harmful user-provided data can affect the program execution.

• File changed: src/com/ibm/security/appscan/altoromutual/servlet/LoginServlet.java
  Enabled HttpOnly and secure flags for cookies

  Enabled 'HttpOnly' and 'secure' flags for cookies. This ensures that client-side scripts are prevented from reading the cookie and the cookie is not transmitted over insecure channels, respectively.