-
Notifications
You must be signed in to change notification settings - Fork 87
Support claude code #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support claude code #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for Anthropic’s Claude Code CLI as a new MCP client manager.
- Introduces
ClaudeCodeManagerto handle installation checks, default configuration, and client metadata. - Exports the new manager in
__init__.pyand registers it inclient_registry.pyfor discovery.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/mcpm/clients/managers/claude_code.py | New manager for Claude Code CLI integration |
| src/mcpm/clients/managers/init.py | Added ClaudeCodeManager to module exports |
| src/mcpm/clients/client_registry.py | Registered "claude-code" key with manager |
Comments suppressed due to low confidence (2)
src/mcpm/clients/managers/claude_code.py:1
- [nitpick] Consider adding a concise one-line summary at the start of the module docstring to improve clarity and follow PEP-257 conventions.
"""
src/mcpm/clients/managers/claude_code.py:39
- Add unit tests for
ClaudeCodeManager(e.g.,_get_empty_config,is_client_installed,get_client_info) to verify expected behaviors and ensure future changes are covered.
def _get_empty_config(self) -> Dict[str, Any]:
| # Claude Code uses .mcp.json in the current working directory for project scope | ||
| # For user scope, it uses the home directory | ||
| # We'll default to user scope configuration | ||
| self.config_path = os.path.expanduser("~/.claude.json") |
Copilot
AI
Jun 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Extract the default config filename (~/.claude.json) into a class-level constant to avoid magic strings and make updates easier.
| self.config_path = os.path.expanduser("~/.claude.json") | |
| self.config_path = self.DEFAULT_CONFIG_PATH |
…to support-claude-code
…to support-claude-code
Added support for claude code as a client