Added support for Claude Code Client #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added claude code client
… support-claude-code
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new Claude Code CLI client integration for the MCP application. Key changes include:
- Introduction of a new file with ClaudeCodeManager to handle the Claude Code CLI integration.
- Updates to the client registry, initialization, and module exports to incorporate the new client.
- Cleanup in router.py to remove a duplicate asyncio import.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mcpm/router/router.py | Removed duplicate asyncio import and re-ordered import statements for clarity. |
| src/mcpm/clients/managers/claude_code.py | Added ClaudeCodeManager that integrates Claude Code CLI functionalities. |
| src/mcpm/clients/managers/init.py | Updated imports and all to export ClaudeCodeManager. |
| src/mcpm/clients/client_registry.py | Added registry mapping for the new "claude-code" client. |
| src/mcpm/clients/init.py | Inserted ClaudeCodeManager into module exports via all. |
Comments suppressed due to low confidence (1)
src/mcpm/clients/managers/claude_code.py:45
- The attribute '_system' used here is not defined within ClaudeCodeManager; please ensure it is properly initialized or inherited to avoid runtime errors.
claude_executable = "claude.exe" if self._system == "Windows" else "claude"
|
🎉 This PR is included in version 1.13.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.