-
Notifications
You must be signed in to change notification settings - Fork 87
feat: support custom node runtime config #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support custom node runtime config #186
Conversation
CI Feedback 🧐(Feedback updated until commit f4b774a)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for custom node runtime configuration and cleans up duplicated test fixtures. Key changes include updating configuration commands and tests to reflect a user-specified node executable, as well as removing redundant monkeypatch setups in tests.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_stash_pop.py | Removed redundant monkeypatch setups and updated expected output. |
| tests/test_remove.py | Removed duplicate test fixture for mocking server not found. |
| tests/test_clients/test_windsurf.py | Removed unused config_manager fixture. |
| tests/test_add.py | Added tests verifying custom node executable configuration. |
| tests/conftest.py | Updated fixture setup to leverage monkeypatch for config manager. |
| src/mcpm/utils/config.py | Added NODE_EXECUTABLES configuration. |
| src/mcpm/commands/target_operations/common.py | Introduced node executable replacement logic in server config. |
| src/mcpm/commands/config.py | Added set and get commands for global configuration. |
| README.zh-CN.md & README.md | Updated documentation to include new configuration commands. |
Comments suppressed due to low confidence (1)
tests/test_remove.py:42
- The mocking of windsurf_manager.get_server appears redundant since it is already set earlier in the test. Consider removing the duplicate setup.
windsurf_manager.get_server = Mock(return_value=None)
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||||
Co-authored-by: qodo-merge-pro[bot] <151058649+qodo-merge-pro[bot]@users.noreply.github.com>
Co-authored-by: qodo-merge-pro[bot] <151058649+qodo-merge-pro[bot]@users.noreply.github.com>
Co-authored-by: qodo-merge-pro[bot] <151058649+qodo-merge-pro[bot]@users.noreply.github.com>
calmini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# [1.14.0](v1.13.6...v1.14.0) (2025-06-24) ### Features * support custom node runtime config ([#186](#186)) ([3c77974](3c77974))
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
User description
Resolves #138
PR Type
Enhancement
Description
Add custom node runtime configuration support
Implement config set/get commands for node executables
Auto-replace node executables based on user config
Clean up test fixtures and improve test structure
Changes walkthrough 📝
3 files
Add config set/get commands for node executablesImplement node executable replacement logicDefine node executables and fix config initialization1 files
Remove Python version compatibility code5 files
Refactor test fixtures and add client registry mocksRemove duplicate mocks and add node config testRemove duplicate config manager fixtureRemove redundant client registry mocksClean up duplicate monkeypatch setup2 files
Document new config set/get commandsAdd Chinese documentation for config commands