-
Notifications
You must be signed in to change notification settings - Fork 87
[generate_manifest] use mcpm registry bot #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe generate-manifest workflow updates the GitHub App token step to use MCPM_REGISTRY_BOT_APP_ID and MCPM_REGISTRY_BOT_PRIVATE_KEY instead of BOT_APP_ID and BOT_PRIVATE_KEY. All steps and control flow remain unchanged; the generated token continues to be used by the subsequent checkout step. Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions (generate-manifest)
participant App as GitHub App Auth
participant Repo as Repository
GH->>App: Generate token using MCPM_REGISTRY_BOT_APP_ID / _PRIVATE_KEY
App-->>GH: Installation access token
GH->>Repo: actions/checkout with token
Repo-->>GH: Sources checked out
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.github/workflows/generate-manifest.yml (4)
25-26: Switched to MCPM_REGISTRY_BOT_ secrets — looks good; verify app installation and secret presence.*The change correctly points the token generation to the registry bot secrets. Ensure:
- The GitHub App (registry bot) is installed on this repo with contents:write and pull-requests:write.
- The repository/org has both secrets set: MCPM_REGISTRY_BOT_APP_ID and MCPM_REGISTRY_BOT_PRIVATE_KEY.
This avoids runtime 401/403s on checkout and PR creation.
I can provide a quick checklist or a dry-run step to fail early if these secrets are missing. Want me to add that?
34-41: Upgrade setup-python and enable pip cache for faster, more reliable runs.Move to the latest major for actions/setup-python and cache pip packages to speed up repeated runs.
Apply this diff:
- - name: Set up Python - uses: actions/setup-python@v4 - with: - python-version: '3.11' + - name: Set up Python + uses: actions/setup-python@v5 + with: + python-version: '3.11' + cache: 'pip'
13-19: Add a concurrency group to prevent branch collisions on simultaneous requests.If two events target the same repo_url concurrently, both will try to push the same branch (add-manifest-...). Use a concurrency group keyed by the target repo URL to serialize runs.
Proposed addition (at the job level):
jobs: generate-manifest: runs-on: ubuntu-latest + concurrency: + group: generate-manifest-${{ github.event.inputs.repo_url || github.event.client_payload.repo_url }} + cancel-in-progress: true permissions: contents: write pull-requests: write
43-49: Confirm the ANYON_API_KEY secret is available and not logged by the script.The step relies on secrets.ANYON_API_KEY. Make sure it exists in repo/org secrets and that scripts/get_manifest.py does not echo it (directly or via verbose HTTP logging).
I can scan the repo for potential leaks (e.g., print statements, logging config) and propose guards if you’d like.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/generate-manifest.yml(1 hunks)
|
🎉 This PR is included in version 2.7.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR Type
Other
Description
Diagram Walkthrough
File Walkthrough
generate-manifest.yml
Update bot credentials to MCPM registry bot.github/workflows/generate-manifest.yml
BOT_APP_IDwithMCPM_REGISTRY_BOT_APP_IDBOT_PRIVATE_KEYwithMCPM_REGISTRY_BOT_PRIVATE_KEYSummary by CodeRabbit