Skip to content

Conversation

@calmini
Copy link
Contributor

@calmini calmini commented Apr 17, 2025

argument value replacement by user input with specific patterns
add --API_KEY==YOUR_API_KEY -> --API_KEY={USER_INPUT_VALUE}
add --API_KEY YOUR_API_KEY -> --API_KEY {USER_INPUT_VALUE}

directly replace env variable value with user input value regardless the env variable value pattern(${VAR},VAR,{VAR},...)

@github-actions
Copy link
Contributor

Semantic Version Check

⚠️ No semantic version changes detected.

Please ensure your commits follow the Conventional Commits format:

  • feat: new feature (triggers MINOR version bump)
  • fix: bug fix (triggers PATCH version bump)
  • BREAKING CHANGE: description (triggers MAJOR version bump)

@calmini calmini requested a review from niechen April 18, 2025 05:49
@niechen
Copy link
Contributor

niechen commented Apr 18, 2025

I think we should still clean up repo server jsons because there might be other programs using these json artifacts. better to keep them clean and organized.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

Semantic Version Check

⚠️ No semantic version changes detected.

Please ensure your commits follow the Conventional Commits format:

  • feat: new feature (triggers MINOR version bump)
  • fix: bug fix (triggers PATCH version bump)
  • BREAKING CHANGE: description (triggers MAJOR version bump)

@calmini
Copy link
Contributor Author

calmini commented Apr 19, 2025

I think we should still clean up repo server jsons because there might be other programs using these json artifacts. better to keep them clean and organized.

Yep, makes sense — this PR tries to be backward-compatible with existing --arg=VAR or --arg VAR patterns found in some server JSONs, perhaps keeping ${VAR} pattern as the recommended format for latter registered servers or introduce a linting tool to keep arguments definition unified.

@calmini calmini closed this Apr 21, 2025
@calmini calmini reopened this Apr 21, 2025
@calmini calmini force-pushed the caozhen/fix-arguments-replace-problem branch from 2ad8e2a to e97b0ec Compare April 21, 2025 09:00
@calmini calmini merged commit f20e469 into main Apr 21, 2025
7 checks passed
@calmini calmini deleted the caozhen/fix-arguments-replace-problem branch April 21, 2025 09:03
mcpm-semantic-release bot pushed a commit that referenced this pull request Apr 21, 2025
## [1.4.2](v1.4.1...v1.4.2) (2025-04-21)

### Bug Fixes

* handle argument value replacement with more patterns ([#75](#75)) ([f20e469](f20e469))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants